Skip to content

feat: add version to about license#1067

Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/add-version-to-about-license
Jan 9, 2026
Merged

feat: add version to about license#1067
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/add-version-to-about-license

Conversation

@jakoballgaier
Copy link
Copy Markdown
Contributor

  • added version placeholder
  • get version from git tag or from package.json

Description

  • added version placeholder
  • get version from git tag or from package.json

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files (TRG 7.02
  • Documentation Notice are present on all affected files (TRG 7.07)
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).
  • Changelog updated (changelog.md) with PR reference and brief summary.
  • Frontend version bumped, if needed (frontend/package.json, frontend/package-lock.json)
  • Backend version bumped, if needed (backend/pom.xml)
  • Open API specification updated, if controllers have been changed (use python script scripts/generate_openapi_yaml.py with running customer backend)

- added version placeholder
- get version from git tag or from package.json
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks! Please bump version also for chart (app and chart version) including README

Comment thread CHANGELOG.md Outdated
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v5.0.2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump appVersion and chartVersion in helm chart. Please remember to update charts/README.md

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

@jakoballgaier sorry misunderstanding. Both changes can be added to 5.1.0 as this version has not been released. I'm not releasing any further version respectlively merge any change prior to yours. Sorry, for inconveniences and being inpreciese :(

@jakoballgaier
Copy link
Copy Markdown
Contributor Author

@tom-rm-meyer-ISST
Sorry for the misunderstanding. I updated the files :)

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a5d60c8 into eclipse-tractusx:main Jan 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants