feat: Implemented days of supply - backend#441
feat: Implemented days of supply - backend#441tom-rm-meyer-ISST merged 8 commits intoeclipse-tractusx:mainfrom
Conversation
feat: implemented the backend for Days of Supply
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for contributing. While reviewing I noticed the duplicate code we currently have in most of the object. I would prefer a refactoring prior to this PR so that we don't have that much duplication e.g., in methods like findAllByFilters. Same applies to new functionality to calculate days of supply which is the same calculation with different parameters.
Beside that:
- Please always wait for the pipeline to finish prior to requesting the review and check the findings. If you're not aware of what to do, please comment.
- Please add javadoc at least for the more complex functions. Normally also at least those should be tested.
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Sorry misclick
There was a problem hiding this comment.
Thanks for contributing and iterating over this with me! Highly appreciated. As we have more than 1kloc of code change, I filed an IP check at EF.
I will approve and merge as soon as the check succeeded.
Beside that: raised #454 to increase maintainability
|
IP check succeeded. Please merge main |
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, IP cleared. Thanks for contributing!
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: