Feat/erpadapter request client#443
Merged
tom-rm-meyer-ISST merged 14 commits intoeclipse-tractusx:mainfrom Jun 20, 2024
Merged
Conversation
tom-rm-meyer-ISST
requested changes
Jun 13, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great contributions. Please check smaller findings :)
tom-rm-meyer-ISST
requested changes
Jun 14, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for the updates! Currently some tests are failing due to missing properties in the test application properties. Beside that we can already include a mechanism to enable /disable the adapter :)
tom-rm-meyer-ISST
requested changes
Jun 17, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great refactoring! Just a few minor things left :)
I meanwhile raised an issue #455 to cleanup conditional properties - We should check that e.g. the application also starts if values are missing if we disable something :)
tom-rm-meyer-ISST
requested changes
Jun 18, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for the refactoring! I just found some styling issues.
tom-rm-meyer-ISST
approved these changes
Jun 20, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great contribution! Thanks a lot! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: