feat: implemented edc data exchange for DemandAndCapacityNotification#447
Merged
tom-rm-meyer-ISST merged 12 commits intoeclipse-tractusx:mainfrom Jun 21, 2024
Conversation
tom-rm-meyer-ISST
requested changes
Jun 13, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for contributing! As always great quality. We have some misunderstanding regarding notifications: these are not added as submodels at the registry for a material.
Let's have a Chat on that :)
tom-rm-meyer-ISST
requested changes
Jun 17, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great refactoring! Only had a few smaller findings. Please merge main; then I'll gonna check it in action :)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| try { | ||
| var data = objectMapper.readTree(body); | ||
| log.info("Received POST request for DemandAndCapacityNotification 2.0.0 with BPNL: " + bpnl); |
Check failure
Code scanning / CodeQL
Log Injection
tom-rm-meyer-ISST
requested changes
Jun 18, 2024
…emantic id from notification asset
| } | ||
| try { | ||
| var data = objectMapper.readTree(body); | ||
| log.info("Received POST request for DemandAndCapacityNotification 2.0.0 with BPNL: " + bpnl); |
Check failure
Code scanning / CodeQL
Log Injection
tom-rm-meyer-ISST
requested changes
Jun 21, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks a lot, please decrease chart version again, as no 2.6.4 has been released yet
tom-rm-meyer-ISST
approved these changes
Jun 21, 2024
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot!
Helm version stays as stated in earlier comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #193 and #196
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: