Skip to content

feat: implemented DemandAndCapacityNotification frontend#451

Merged
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/demand-and-capacity-notifcation-frontend
Jun 17, 2024
Merged

feat: implemented DemandAndCapacityNotification frontend#451
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/demand-and-capacity-notifcation-frontend

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jun 14, 2024

Description

  • implemented a new view for displaying DemandAndCapacityNotifications
  • notifications are divided in incoming and outgoing notifications
  • new notifications can be created through a modal

resolves #315

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ReneSchroederLJ ReneSchroederLJ marked this pull request as ready for review June 14, 2024 13:53
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Great Quality! Just had a few findings or questions. please check

Comment thread frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated
Comment thread frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated
Comment thread frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated
Comment thread frontend/src/features/notifications/components/NotificationInformationModal.tsx Outdated
Comment thread frontend/src/views/DemandCapacityNotificationView.tsx Outdated
Comment thread frontend/src/views/DemandCapacityNotificationView.tsx Outdated
Comment thread frontend/src/views/DemandCapacityNotificationView.tsx Fixed
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your efforts!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 1c06609 into eclipse-tractusx:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Message Frontend

3 participants