refactor: add deployment script for local deployment#469
Conversation
427a3a2 to
020af38
Compare
020af38 to
671534a
Compare
b5ccf25 to
fa885eb
Compare
fa885eb to
c6a01e8
Compare
|
Two things to consider:
|
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
Great contribution. The deployment script works really well. Mainly some suggestions for usability and documentation.
However, there is one bigger topic. I realized that all scripts in the repo are defined with the shebang for bash ( #!/bin/bash ), but being run with the regular sh shell. The regular shell doesn't support all features of bash. Currently this is not leading to compatibility issues, but we shouldn't rely on it.
This could either be remedied by changing the files to use #!/bin/sh or running them with bash instead.
77f87b8 to
c0208e2
Compare
|
updated shebang. Version bump to be done. This pr does a patch level change to the backend while minor to the chart due to the actuator plugin replacing the health endpoint |
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
LGTM thank you for your work
|
@mhellmeier The chart is failing on purpose. I know it's > 1kloc but only I've been working on it. |
mhellmeier
left a comment
There was a problem hiding this comment.
Please adjust the license header years to the correct years.
| # Copyright (c) 2023,2024 Volkswagen AG | ||
| # Copyright (c) 2024 Fraunhofer-Gesellschaft zur Foerderung der angewandten Forschung e.V. (represented by Fraunhofer ISST) | ||
| # Copyright (c) 2023,2024 Contributors to the Eclipse Foundation |
Co-authored-by: Malte Hellmeier <git@mhellmeier.de>
mhellmeier
left a comment
There was a problem hiding this comment.
Thanks for updating. The failed pipeline aspect was already discussed. The >1k LOC are okay for me since you are a Committer, and they are mostly related due to auto-generated files like JSON package lock files.
15fdd07
into
eclipse-tractusx:main
Description
The following changes have been made:
local)local/package.jsonto use the bruno cli to seed the int test data, if wanteddeploy.shwhich provides one-line deployments for common scenarios (full clean, only clean and create puris and direct direct dependencies, also seed int test data)dns-host-resolver)deploy.sh)Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: