fix/check_obligations_and_prohibitions

[eschrewe]

Description

• the policy check method of the EdcAdapterService class did not check for any possible contents of the rule type "prohibition" or "obligation" when testing whether a partner's policy in a contract offer was acceptable
• added some code to the "testContractPolicyConstraints" method to fix this
• added unit tests for these cases

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files
• If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

[tom-rm-meyer-ISST]

Thanks a lot and great catch :) only had small findings and one point for discussion :)

[tom-rm-meyer-ISST]

Please remove print line and duplicate blank line.

[tom-rm-meyer-ISST]

Checked for other method: let's make the validJson and invalidJson.

[tom-rm-meyer-ISST]

I was wondering if it makes sense to summarize the two tests into one parametrized test like in mad for the pattern checks.
Then I would propose to make the jsons constants with names like CATALOG_PROHIBITION_SET_NOT_ALLOWED and a comment. That would keep some readability.

Being honest: I also like the test name stating directly wrongProhibition and wrongObligation directly in the beginning. So this is not a neccessary change but an idea - only adapt if you like it better, because I'm not sure what's easier to maintain :)

[tom-rm-meyer-ISST]

LGTM, thanks a lot!