feat: demand and capacity notification improvements#576
Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom Oct 2, 2024
Merged
Conversation
tom-rm-meyer-ISST
requested changes
Sep 9, 2024
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Please test correct mapping of all fields. Beside that you solved #486 ! Thanks a lot :)
This was
linked to
issues
Sep 9, 2024
tom-rm-meyer-ISST
requested changes
Sep 11, 2024
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Currently only serialization has been checked with regard to material mapping. Please also add mapping assertions for deserialization.
tom-rm-meyer-ISST
approved these changes
Oct 2, 2024
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: