chore: cleanup erpadapterrequest

[eschrewe]

Description

• added validation for currently unsupported request types
• fixed erp response url
• fixed bug in PartnerControllerTest (missing mock)
• solves Refactor ErpAdapterService #419

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

• DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
• Copyright and license header are present on all affected files
• If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

[tom-rm-meyer-ISST]

Thanks a lot (also for fixing the PartnerControllerTest)! Checked the issue again: Currently there is still the need to provide tests for the mapping of responses.
Note: as this PR is concise I could also split the issue into two tickets. Please let me know what you prefer :)

[eschrewe]

After taking a closer look, I noticed that the Asset Type validation was not working correctly in the Unit tests, so I did some refactoring here.

Regarding the issue of adding additional tests for the mapping of responses, I think it'd be best if we wait for detailed feedback from the other team, that is currently supposed to work on the erp-adapter project (Gerhard). Maybe they come up with a request to change to API a bit, or something like that...

[tom-rm-meyer-ISST]

After taking a closer look, I noticed that the Asset Type validation was not working correctly in the Unit tests, so I did some refactoring here.

Regarding the issue of adding additional tests for the mapping of responses, I think it'd be best if we wait for detailed feedback from the other team, that is currently supposed to work on the erp-adapter project (Gerhard). Maybe they come up with a request to change to API a bit, or something like that...

One could argue for both as likely changes won't be fundamental (I expect). As proposed I've split #419 into #584 and #583. This issue solves #584

Is this pr ready for review? :)

[eschrewe]

After taking a closer look, I noticed that the Asset Type validation was not working correctly in the Unit tests, so I did some refactoring here.
Regarding the issue of adding additional tests for the mapping of responses, I think it'd be best if we wait for detailed feedback from the other team, that is currently supposed to work on the erp-adapter project (Gerhard). Maybe they come up with a request to change to API a bit, or something like that...

One could argue for both as likely changes won't be fundamental (I expect). As proposed I've split #419 into #584 and #583. This issue solves #584

Is this pr ready for review? :)

Yes

[tom-rm-meyer-ISST]

LGTM, thanks for contributing!