Skip to content

ci: add workflow for backend unit tests#616

Merged
mhellmeier merged 1 commit intoeclipse-tractusx:mainfrom
FraunhoferISST:ci/backend-test
Oct 14, 2024
Merged

ci: add workflow for backend unit tests#616
mhellmeier merged 1 commit intoeclipse-tractusx:mainfrom
FraunhoferISST:ci/backend-test

Conversation

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Oct 2, 2024

Description

To ensure we don't miss existing unit tests during update, I added a workflow to run unit tests in the backend during PR.

Will undo making one test fail after functional review.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the base branch from ci/backend-test to main October 2, 2024 16:22
@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the ci/backend-test branch 3 times, most recently from f29eaff to 141bb95 Compare October 2, 2024 16:25
Copy link
Copy Markdown
Contributor

@eschrewe eschrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks very much. I'd just say we better use release versions of those actions.

Comment thread .github/workflows/unit-test-backend.yaml
Comment thread .github/workflows/unit-test-backend.yaml
@eschrewe eschrewe self-requested a review October 14, 2024 08:16
Copy link
Copy Markdown
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhellmeier mhellmeier changed the title Ci: add workflow for backend unit tests ci: add workflow for backend unit tests Oct 14, 2024
@mhellmeier mhellmeier merged commit c93ab55 into eclipse-tractusx:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants