Skip to content

feat: implemented material list view#732

Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:feat/916-enhance-uifrom
achtzig20:feat/material-list-view
Jan 21, 2025
Merged

feat: implemented material list view#732
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:feat/916-enhance-uifrom
achtzig20:feat/material-list-view

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jan 14, 2025

Description

  • implemented a searchable material list
  • the list view is the new initial landing page of the app
  • clicking on a material navigates to a details page

#702

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

As I missed the meetings:

  • I don't see a user story in eclipse-tractusx/sig-release#916
    • that links the material list view directly to the dashboard - is that planned?
    • that implements the details view (currently placeholder)
  • Please tick the review boxes in the pr if you checked it (it's meant for the PRing person)
  • As the direction is derived based on partners, will that reflected somewhere in the material view?

Comment thread frontend/src/features/material-list/components/MaterialList.tsx Outdated
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looks great. Please handle bruno updates.

Comment thread frontend/src/views/MaterialListView.tsx Outdated
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution!

@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jan 21, 2025 that may be closed by this pull request
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 0ce9b06 into eclipse-tractusx:feat/916-enhance-ui Jan 21, 2025
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Feb 11, 2025
3 tasks
@ReneSchroederLJ ReneSchroederLJ deleted the feat/material-list-view branch October 8, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Material Search View

2 participants