Skip to content

feat: material details view#747

Merged
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:feat/916-enhance-uifrom
achtzig20:material-details
Jan 24, 2025
Merged

feat: material details view#747
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:feat/916-enhance-uifrom
achtzig20:material-details

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jan 23, 2025 •
edited
Loading

Description

  • implements the Material Details View
  • adds logic for displaying and selecting calendar weeks
  • utilizes the reworked modal logic

partial implementation of #737

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Looks and works great. Just had one bug and one question

Comment thread ...ava/org/eclipse/tractusx/puris/backend/delivery/logic/service/DeliveryRequestApiService.java
Comment thread frontend/src/features/material-details/components/MaterialDetailsHeader.tsx Outdated
tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jan 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit bb782a6 into eclipse-tractusx:feat/916-enhance-ui Jan 24, 2025
This was referenced Jan 27, 2025
Merged
Closed
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Feb 11, 2025
Merged
3 tasks
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Feb 25, 2025
Closed
@ReneSchroederLJ ReneSchroederLJ deleted the material-details branch October 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReneSchroederLJ @tom-rm-meyer-ISST
⚡