feat: bruno integration tests for days of supply#752
Merged
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom Feb 20, 2025
Merged
feat: bruno integration tests for days of supply#752tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
Conversation
tom-rm-meyer-ISST
requested changes
Feb 6, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for your contribution. Overall great, please check the comments.
tom-rm-meyer-ISST
requested changes
Feb 20, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Please merge main so that the calculation is also correct (checked only against branch logic).
Days of Supply currently is missing in tests for EDC contracts and for DTR SubmodelDescriptors. Do you want to do that in an additional PR or include in this one?
|
|
||
| const responseJson = res.getBody(); | ||
|
|
||
| test("Verify response contains 27 daysOfSupply items", function () { |
Contributor
There was a problem hiding this comment.
length is 28 which I think is correct
tom-rm-meyer-ISST
approved these changes
Feb 20, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, retest had some time issue again. But previous test was fine. Thus, thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: