Skip to content

Fix/days of supply calculation#773

Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
achtzig20:fix/days-of-supply-calculation
Feb 14, 2025
Merged

Fix/days of supply calculation#773
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
achtzig20:fix/days-of-supply-calculation

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Feb 12, 2025

Description

  • adjusted the calculation of days of supply to be in line with the standard
  • notable differences are:
    • actual item stock is displayed on the previous day
    • days of supply compares the current stock in a day to demands/outgoing shipments of the upcoming days
    • incoming deliveries/production are not included in the calculation for a single day
  • a unit test for the calculation was provided
    • the test uses the sample data provided in the standard document
    • note: There seems to be a mistake in the standard data. the days of supply for day 5 should be 0

resolves #771

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fast fix! Had smaller findings. Please check.

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 405af95 into eclipse-tractusx:main Feb 14, 2025
@ReneSchroederLJ ReneSchroederLJ deleted the fix/days-of-supply-calculation branch October 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve Todo for optional partnerBpnl

3 participants