feat: integrate stock view into material details view#778
Merged
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom Feb 20, 2025
Merged
Conversation
tom-rm-meyer-ISST
requested changes
Feb 20, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great work, thanks for your contribution!
Found smaller issues.
Beside that: Production and Demand can't be deleted. If it's a small change, please consider doing it with this pr. Else please raise an issue.
tom-rm-meyer-ISST
requested changes
Feb 20, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Small typographie left and please put an answer to remaining old comment.
tom-rm-meyer-ISST
approved these changes
Feb 20, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #208
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: