Skip to content

feat: automatic partner data refreshing when new data is available#847

Merged
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom
achtzig20:automatic-data-refresh
May 9, 2025
Merged

feat: automatic partner data refreshing when new data is available#847
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom
achtzig20:automatic-data-refresh

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Apr 22, 2025

Description

  • implemented websockets to notify the frontend
  • added logic to the frontend to refresh partner data when receiving a notification
  • added an application property for allowed origins

resolves #314

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, love the functionality! Also you solved #141. Just had minor findings. Currently due to the downtime of some eclipse foundation services (see status) merging is blocked. We might need to temporarily outcomment the eclipse dashtool plugin to create a release candidate.

Comment thread frontend/src/features/material-details/components/MaterialDetails.tsx Outdated
Comment thread charts/puris/values.yaml
Comment thread charts/puris/templates/backend-deployment.yaml Outdated
@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

Raised IP checks for libraries involved in frontend

[main] INFO A review is required for npm/npmjs/-/eventsource/2.0.2.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21019 .
[main] INFO A review is required for npm/npmjs/-/react-stomp-hooks/3.0.1.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21020 .

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo still present.

Frontend contains restricted libraries. Filed ip tickets for those.

Further I'm confused: Both, frontend and backend state that the dash.jar file would be corrupt. Trying it out with act locally, I don't run into that failure when using version 1.1.0. As long as the job runs through, it's fine. But it makes sense to ask wayne regarding this issue

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

Raised IP checks for libraries involved in frontend

[main] INFO A review is required for npm/npmjs/-/eventsource/2.0.2. [main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21019 . [main] INFO A review is required for npm/npmjs/-/react-stomp-hooks/3.0.1. [main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/21020 .

Both checks succeeded, please regenerate / update the files @ReneSchroederLJ

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the DEPENDENCIES files. Could you please commit the typo in line 145 of src/features/material-details/components/MaterialDetails.tsx?

@ReneSchroederLJ
Copy link
Copy Markdown
Member Author

Thanks for updating the DEPENDENCIES files. Could you please commit the typo in line 145 of src/features/material-details/components/MaterialDetails.tsx?

There seems to be a mistake with GitHub's display. The typo was already fixed in a previous commit.

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

Thanks for updating the DEPENDENCIES files. Could you please commit the typo in line 145 of src/features/material-details/components/MaterialDetails.tsx?

There seems to be a mistake with GitHub's display. The typo was already fixed in a previous commit.

Rechecked again and you're right. That's crazy because I checked that in the files changed tab to not confuse the outdated comment. Thanks for the work!

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Notifications for updates to reported data

3 participants