Skip to content

feat: extended days of supply unit tests with edge cases#870

Merged
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
achtzig20:days-of-supply-unit-tests
May 16, 2025
Merged

feat: extended days of supply unit tests with edge cases#870
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
achtzig20:days-of-supply-unit-tests

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented May 15, 2025

Description

  • extended days of supply unit tests:
    • test for insufficient number of days
    • initial stock of 0
    • mixed own and reported deliveries

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this took me some time. Revisiting this, I'm not sure if we should reiterate the deliveries standard, as there will likely be spec gaps.

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add CHANGLEOG.md entry

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 69f089a into eclipse-tractusx:main May 16, 2025
13 checks passed
@ReneSchroederLJ ReneSchroederLJ deleted the days-of-supply-unit-tests branch October 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants