Skip to content

feat: use keycloak to authorize backend calls from the frontend#896

Merged
tom-rm-meyer-ISST merged 10 commits intoeclipse-tractusx:mainfrom
achtzig20:keycloak-authentication
Jul 2, 2025
Merged

feat: use keycloak to authorize backend calls from the frontend#896
tom-rm-meyer-ISST merged 10 commits intoeclipse-tractusx:mainfrom
achtzig20:keycloak-authentication

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jun 23, 2025

Description

  • removed API key authorization from frontend
  • added keycloak authorization as a second authorization option to the backend
  • updated frontend to send keycloak's access token as bearer
  • added keycloak to local docker compose deployment
  • separated idp config from frontend in values.yaml
  • updated admin and migration guide

solves #902, #903

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature works great locally.

Tests and helm chart are failing. Proposed changes to fix it.

Further the local deployment can be less ressource intense.

Nevertheless - as always - good work!

Comment thread CHANGELOG.md Outdated
Comment thread charts/puris/values.yaml Outdated
Comment thread docs/admin/Admin_Guide.md
Comment thread docs/admin/Migration_Guide.md Outdated
Comment thread local/docker-compose.yaml
Comment thread backend/src/main/resources/application.properties Outdated
Comment thread backend/src/main/resources/application.properties Outdated
Comment thread charts/puris/templates/backend-deployment.yaml Outdated
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

Please check comment + the notification dialog results in an api key exception. Likely this dialog has been missed.

Comment thread backend/pom.xml
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. please bump backend and frontend version

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit a085fe7 into eclipse-tractusx:main Jul 2, 2025
14 checks passed
@ReneSchroederLJ ReneSchroederLJ deleted the keycloak-authentication branch October 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants