Skip to content

feat: rework validation logic to return errors as strings#907

Merged
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom
achtzig20:validation-improvements
Jul 6, 2025
Merged

feat: rework validation logic to return errors as strings#907
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom
achtzig20:validation-improvements

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jul 4, 2025

Description

  • refactored validation for Demand, Production, Delivery and Stock to return detailed error messages
  • the data import API now returns the detailed errors
  • refined swagger annotations for data import

resolves #906

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great enhancements! I tracked the changes in this comment also within 906. (small things open).

I noticed the following:

  • a few validations missing (also previously in the validate method) like order positions or address cross check
  • semantics to be improved in the error message
  • harmonization of . at the end of the message (this was wrong in two services, resulting in the majority of the comments)

I used the attached files for easer tracking with no int seed.
delivery.xlsx
demand.xlsx
production_no_fail.xlsx
stock_soft_fail.xlsx

Comment thread CHANGELOG.md Outdated
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast improvements!

Found a feww smaller things to consider.

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for iterating over this topic with me! Great feature!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit e515611 into eclipse-tractusx:main Jul 6, 2025
13 checks passed
@ReneSchroederLJ ReneSchroederLJ deleted the validation-improvements branch October 8, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor validation logic to give detailed error insights

2 participants