feat: rework validation logic to return errors as strings#907
Merged
tom-rm-meyer-ISST merged 6 commits intoeclipse-tractusx:mainfrom Jul 6, 2025
Merged
Conversation
tom-rm-meyer-ISST
requested changes
Jul 5, 2025
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Great enhancements! I tracked the changes in this comment also within 906. (small things open).
I noticed the following:
- a few validations missing (also previously in the validate method) like order positions or address cross check
- semantics to be improved in the error message
- harmonization of
.at the end of the message (this was wrong in two services, resulting in the majority of the comments)
I used the attached files for easer tracking with no int seed.
delivery.xlsx
demand.xlsx
production_no_fail.xlsx
stock_soft_fail.xlsx
tom-rm-meyer-ISST
requested changes
Jul 6, 2025
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for the fast improvements!
Found a feww smaller things to consider.
tom-rm-meyer-ISST
approved these changes
Jul 6, 2025
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks a lot for iterating over this topic with me! Great feature!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #906
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: