Skip to content

Feat: add liquibase for database migrations#913

Merged
tom-rm-meyer-ISST merged 10 commits intoeclipse-tractusx:mainfrom
FraunhoferISST:feat/add-liquibase
Jul 9, 2025
Merged

Feat: add liquibase for database migrations#913
tom-rm-meyer-ISST merged 10 commits intoeclipse-tractusx:mainfrom
FraunhoferISST:feat/add-liquibase

Conversation

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Jul 8, 2025

Description

solves #799

Adds

  • liquibase dependency to pom
  • liquibase migrations for
    • 3.1.0 schema as baseline
    • 3.2.0 schema as migration
  • updated local deployment
    • to use liquibase migrations
    • by adding a liquibase dumper
  • updated chart to only validate schema
  • updated documentation

helm chart and version have already been up to date due to unpublished release.

Please note: around 2k alone are the baseline scheme autogenerated. As a committer, I don't see IP concerns even if the size is bigger than the average pr.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor Author

raised ip lab issue for liquibase 4.32.0: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/22467

Might downgrade if today is not sent out

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review July 8, 2025 14:35
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job. Just some minor details and some questions regarding the use of foreign keys.

Comment thread CHANGELOG.md Outdated
Comment thread backend/pom.xml Outdated
@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor Author

helm test now works. Version has not been bumped as this version number is unreleased.

Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your efforts. Great work

Copy link
Copy Markdown
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see a possible problem in the >1k LOC changes and the failing pipeline. Since the first thing is argumented by the committer @tom-rm-meyer-ISST

Please note: around 2k alone are the baseline scheme autogenerated. As a committer, I don't see IP concerns even if the size is bigger than the average pr.

and the failed pipeline is related to the version change, I would approve.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 6ad3b85 into eclipse-tractusx:main Jul 9, 2025
13 of 14 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST linked an issue Jul 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing indicators for mandatory fields

4 participants