Skip to content

feat: update notification api#921

Merged
tom-rm-meyer-ISST merged 3 commits intoeclipse-tractusx:mainfrom
achtzig20:update-notification-api
Jul 31, 2025
Merged

feat: update notification api#921
tom-rm-meyer-ISST merged 3 commits intoeclipse-tractusx:mainfrom
achtzig20:update-notification-api

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jul 22, 2025

Description

  • updated the implementation of DemandAndCapacityNotification to version 2 of the standard
  • updated Bruno integration tests to enable testing for notification forwarding
    • added 2 partners to supplier
    • added one notification from each partner for the same disruption

resolves #917, #919

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jul 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall great pr! The number of comments is just high as I pointed also to the repetitive potential findings (might be handled in the follow up issues) :)

Comment thread CHANGELOG.md Outdated
Comment thread ...andandcapacitynotification/controller/DemandAndCapacityNotificationRequestApiController.java
Comment thread .../puris/backend/demandandcapacitynotification/domain/model/DemandAndCapacityNotification.java
Comment thread ...d/demandandcapacitynotification/logic/dto/demandandcapacitynotficationsamm/MaterialSamm.java
Comment thread backend/src/main/resources/db/changelog/changelog-3.x/changelog-3.3.0..yaml
Comment thread ...demandandcapacitynotification/logic/adapter/DemandAndCapacityNotificationSammMapperTest.java Outdated
Comment thread docs/api/openAPI.yaml
Comment thread frontend/src/models/types/data/demand-capacity-notification.ts
Comment thread local/postman/README.md Outdated
Comment thread local/postman/README.md
tom-rm-meyer-ISST
tom-rm-meyer-ISST reviewed Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the incorporation. Three conversations are still open. Two likely without any change intended. Please check.

@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request Jul 31, 2025
Closed
tom-rm-meyer-ISST
tom-rm-meyer-ISST requested changes Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

tom-rm-meyer-ISST
tom-rm-meyer-ISST approved these changes Jul 31, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misclicked again.

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 53acfef into eclipse-tractusx:main Jul 31, 2025
13 checks passed
@ReneSchroederLJ ReneSchroederLJ deleted the update-notification-api branch October 8, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tom-rm-meyer-ISST tom-rm-meyer-ISST tom-rm-meyer-ISST approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update notification API

2 participants

@ReneSchroederLJ @tom-rm-meyer-ISST
⚡