feat: added unit test for excel service#922
Merged
tom-rm-meyer-ISST merged 3 commits intoeclipse-tractusx:mainfrom Jul 31, 2025
Merged
feat: added unit test for excel service#922tom-rm-meyer-ISST merged 3 commits intoeclipse-tractusx:mainfrom
tom-rm-meyer-ISST merged 3 commits intoeclipse-tractusx:mainfrom
Conversation
tom-rm-meyer-ISST
approved these changes
Jul 30, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for adding these tests! Only very small things (maybe even optional) put into review :)
tom-rm-meyer-ISST
requested changes
Jul 30, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
misclicked before
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, please rebase!
tom-rm-meyer-ISST
approved these changes
Jul 31, 2025
Contributor
tom-rm-meyer-ISST
left a comment
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #910
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: