Skip to content

feat: add role-based permission handling#925

Merged
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/role-based-permissions
Aug 4, 2025
Merged

feat: add role-based permission handling#925
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
achtzig20:feat/role-based-permissions

Conversation

@ReneSchroederLJ
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ commented Jul 31, 2025

Description

  • added role-based permission handling
  • added swagger annotations for admin routes

resolves #904

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your efforts. I'm with you regarding the swagger-ui. I'm not interested into adding further third party tooling to document RBAC. Nevertheless, please update the documentation (admin guide, arc42).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update Admin Guide and Arc42:

  • API-Key automatically has the ADMIN role and access to all APIs
  • User role allows only read access to Master Data and no Access to EDC Controller (= EDC Views)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Admin Guide, but the change to the Arc42 documentation should probably be handled in #924 .

Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 8157ef4 into eclipse-tractusx:main Aug 4, 2025
13 checks passed
@ReneSchroederLJ ReneSchroederLJ deleted the feat/role-based-permissions branch October 8, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Role-based permissions

3 participants