feat: add role-based permission handling#925
Merged
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom Aug 4, 2025
Merged
feat: add role-based permission handling#925tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
tom-rm-meyer-ISST merged 2 commits intoeclipse-tractusx:mainfrom
Conversation
tom-rm-meyer-ISST
requested changes
Jul 31, 2025
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks for your efforts. I'm with you regarding the swagger-ui. I'm not interested into adding further third party tooling to document RBAC. Nevertheless, please update the documentation (admin guide, arc42).
Contributor
There was a problem hiding this comment.
Please update Admin Guide and Arc42:
- API-Key automatically has the ADMIN role and access to all APIs
- User role allows only read access to Master Data and no Access to EDC Controller (= EDC Views)
Member
Author
There was a problem hiding this comment.
I updated the Admin Guide, but the change to the Arc42 documentation should probably be handled in #924 .
tom-rm-meyer-ISST
approved these changes
Aug 4, 2025
Contributor
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #904
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: