feat: update notification frontend#926
feat: update notification frontend#926tom-rm-meyer-ISST merged 5 commits intoeclipse-tractusx:mainfrom
Conversation
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for your first contribution! Works very well. I only found a few things that need to be considered for now. Please check.
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for the fast incorporations. Noticed one thing I missed during review. Please update and I'll merge! :)
| @@ -112,56 +124,85 @@ const DemandCapacityNotificationView = ({ demandCapacityNotification, partners } | |||
| <FormLabel>Text</FormLabel> | |||
There was a problem hiding this comment.
| <FormLabel>Text</FormLabel> | |
| <FormLabel>Text*</FormLabel> |
Didn't see that last time. There should be an asteric to indicate the mandatoryness now.
There was a problem hiding this comment.
Sorry for missing that small detail, thanks for catching it! :)
There was a problem hiding this comment.
Thanks for the further consistent changes! While walking through the changes, I noticed that we should also add the asteric for the resolution modal. Please incroporate that, too :)
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
Thanks for further iterating over it! You already increased quality. Sorry for not seeing the things in the comments directly. Please check & incorporate.
| @@ -112,56 +124,85 @@ const DemandCapacityNotificationView = ({ demandCapacityNotification, partners } | |||
| <FormLabel>Text</FormLabel> | |||
There was a problem hiding this comment.
Thanks for the further consistent changes! While walking through the changes, I noticed that we should also add the asteric for the resolution modal. Please incroporate that, too :)
tom-rm-meyer-ISST
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for iterating over that with me AND your first contribution! :)
Description
Resolves #918
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: