feat(backend/dtr): suppress dtr asset and contract creation via parameter#963
Conversation
15afc95 to
52a79f6
Compare
There was a problem hiding this comment.
Thank you for your great contribution. Very in-depth and useful. I noticed some bugs that need to be addressed and I ran into an issue with the bru CLI.
Regarding the use of the bru CLI:
At the moment, despite having a local NPM environment for the integration tests, we use the globally installed version of the bru CLI for running the integration tests.
In practice this leads to 2 issues:
- the bru CLI needs to be installed globally to run the integration tests
- a certain minimum version of the CLI is required to get the expected results
The latter issue came up for me during review. I was running version 2.1.0 of the CLI, which does not support all flags used in the new bru run command. I updated to the latest version 2.10.1 to fix the issue, but it would be desirable to provide guidance for users of the repo on how to use the integration tests.
I would suggest we either document the need for a global installation of the CLI including a minimum version or even better update the versions listed in the package.json and switch to using a local installation of the CLI if possible.
Fair, updated documentation and bumped the version. I requested IP clarification on several items, thus the IP check failes: [main] INFO This content is either not correctly mapped by the system, or requires review. |
ReneSchroederLJ
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the quick iteration. Works like a charm with the local bruno version.
mhellmeier
left a comment
There was a problem hiding this comment.
LGTM. The dependency checks are okay now. The >1000 LOC are mostly related to the nearly 10k package-lock.json file. It it sill okay since the PR owner is a Committer (see TRG 7.00).
Description
solves #964
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: