Skip to content

feat(backend/dtr): suppress dtr asset and contract creation via parameter#963

Merged
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
FraunhoferISST:fix/960-dont-duplicate-dtr-contracts
Sep 8, 2025
Merged

feat(backend/dtr): suppress dtr asset and contract creation via parameter#963
tom-rm-meyer-ISST merged 4 commits intoeclipse-tractusx:mainfrom
FraunhoferISST:fix/960-dont-duplicate-dtr-contracts

Conversation

@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Sep 5, 2025

Description

solves #964

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

@tom-rm-meyer-ISST tom-rm-meyer-ISST force-pushed the fix/960-dont-duplicate-dtr-contracts branch from 15afc95 to 52a79f6 Compare September 5, 2025 09:22
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contribution. Very in-depth and useful. I noticed some bugs that need to be addressed and I ran into an issue with the bru CLI.

Regarding the use of the bru CLI:

At the moment, despite having a local NPM environment for the integration tests, we use the globally installed version of the bru CLI for running the integration tests.

In practice this leads to 2 issues:

  • the bru CLI needs to be installed globally to run the integration tests
  • a certain minimum version of the CLI is required to get the expected results

The latter issue came up for me during review. I was running version 2.1.0 of the CLI, which does not support all flags used in the new bru run command. I updated to the latest version 2.10.1 to fix the issue, but it would be desirable to provide guidance for users of the repo on how to use the integration tests.

I would suggest we either document the need for a global installation of the CLI including a minimum version or even better update the versions listed in the package.json and switch to using a local installation of the CLI if possible.

Comment thread local/deploy.sh Outdated
Comment thread local/postman/README.md Outdated
Comment thread local/bruno/puris-integration-test/environments/local.bru Outdated
@tom-rm-meyer-ISST
Copy link
Copy Markdown
Contributor Author

Thank you for your great contribution. Very in-depth and useful. I noticed some bugs that need to be addressed and I ran into an issue with the bru CLI.

Regarding the use of the bru CLI:

At the moment, despite having a local NPM environment for the integration tests, we use the globally installed version of the bru CLI for running the integration tests.

In practice this leads to 2 issues:

  • the bru CLI needs to be installed globally to run the integration tests
  • a certain minimum version of the CLI is required to get the expected results

The latter issue came up for me during review. I was running version 2.1.0 of the CLI, which does not support all flags used in the new bru run command. I updated to the latest version 2.10.1 to fix the issue, but it would be desirable to provide guidance for users of the repo on how to use the integration tests.

I would suggest we either document the need for a global installation of the CLI including a minimum version or even better update the versions listed in the package.json and switch to using a local installation of the CLI if possible.

Fair, updated documentation and bumped the version. I requested IP clarification on several items, thus the IP check failes:

[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for npm/npmjs/@smithy/node-http-handler/4.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23206 .
[main] INFO A review is required for npm/npmjs/@smithy/smithy-client/4.6.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23207 .
[main] INFO A review is required for npm/npmjs/@smithy/util-config-provider/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23208 .
[main] INFO A review is required for npm/npmjs/@smithy/util-defaults-mode-node/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23209 .
[main] INFO A review is required for npm/npmjs/@usebruno/js/0.37.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23210 .
[main] INFO A review is required for npm/npmjs/@usebruno/lang/0.28.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23211 .
[main] INFO A review is required for npm/npmjs/@smithy/node-config-provider/4.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23212 .
[main] INFO A review is required for npm/npmjs/@smithy/util-defaults-mode-browser/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23213 .
[main] INFO A review is required for npm/npmjs/@smithy/types/4.4.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23214 .
[main] INFO A review is required for npm/npmjs/@smithy/invalid-dependency/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23215 .
[main] INFO A review is required for npm/npmjs/@smithy/util-uri-escape/4.1.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23216 .
[main] INFO A review is required for npm/npmjs/@smithy/util-utf8/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23217 .
[main] INFO A review is required for npm/npmjs/@smithy/middleware-content-length/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23218 .
[main] INFO A review is required for npm/npmjs/@usebruno/schema/0.18.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23219 .
[main] INFO A review is required for npm/npmjs/@usebruno/crypto-js/3.1.9.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23220 .
[main] INFO A review is required for npm/npmjs/@smithy/util-body-length-node/4.1.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23221 .
[main] INFO A review is required for npm/npmjs/@smithy/querystring-builder/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23222 .
[main] INFO A review is required for npm/npmjs/@smithy/config-resolver/4.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23223 .
[main] INFO A review is required for npm/npmjs/@smithy/is-array-buffer/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23224 .
[main] INFO A review is required for npm/npmjs/@smithy/middleware-endpoint/4.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23225 .
[main] INFO A review is required for npm/npmjs/@usebruno/filestore/0.2.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23226 .
[main] INFO A review is required for npm/npmjs/@smithy/fetch-http-handler/5.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23227 .
[main] INFO A review is required for npm/npmjs/@smithy/abort-controller/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23228 .
[main] INFO A review is required for npm/npmjs/@smithy/shared-ini-file-loader/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23229 .
[main] INFO A review is required for npm/npmjs/@smithy/credential-provider-imds/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23230 .
[main] INFO A review is required for npm/npmjs/@smithy/util-middleware/4.1.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23231 .
[main] INFO A review is required for npm/npmjs/-/flow-parser/0.281.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23232 .
[main] INFO A review is required for npm/npmjs/@smithy/url-parser/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23233 .
[main] INFO A review is required for npm/npmjs/-/quickjs-emscripten-core/0.29.2.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23234 .
[main] INFO A review is required for npm/npmjs/@usebruno/common/0.11.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23235 .
[main] INFO A review is required for npm/npmjs/@smithy/signature-v4/5.2.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23236 .
[main] INFO A review is required for npm/npmjs/@smithy/util-body-length-browser/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23237 .
[main] INFO A review is required for npm/npmjs/@smithy/middleware-serde/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23238 .
[main] INFO A review is required for npm/npmjs/@smithy/property-provider/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23239 .
[main] INFO A review is required for npm/npmjs/@smithy/util-base64/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23240 .
[main] INFO A review is required for npm/npmjs/@smithy/core/3.10.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23241 .
[main] INFO A review is required for npm/npmjs/-/js-md4/0.3.2.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23242 .
[main] INFO A review is required for npm/npmjs/@usebruno/requests/0.8.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23243 .
[main] INFO A review is required for npm/npmjs/@smithy/middleware-retry/4.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23244 .
[main] INFO A review is required for npm/npmjs/@smithy/protocol-http/5.2.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23245 .
[main] INFO A review is required for npm/npmjs/@usebruno/cli/2.10.1.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23246 .
[main] INFO A review is required for npm/npmjs/@smithy/util-retry/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23247 .
[main] INFO A review is required for npm/npmjs/@smithy/util-stream/4.3.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23248 .
[main] INFO A review is required for npm/npmjs/-/postman-request/2.88.1-postman.43.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23249 .
[main] INFO A review is required for npm/npmjs/@usebruno/converters/0.11.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23250 .
[main] INFO A review is required for npm/npmjs/@smithy/middleware-stack/4.1.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23251 .
[main] INFO A review is required for npm/npmjs/-/jscodeshift/17.3.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23252 .
[main] INFO A review is required for npm/npmjs/@smithy/util-buffer-from/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23253 .
[main] INFO A review is required for npm/npmjs/-/grpc-reflection-js/0.3.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23254 .
[main] INFO A review is required for npm/npmjs/@smithy/util-hex-encoding/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23255 .
[main] INFO A review is required for npm/npmjs/@smithy/util-endpoints/3.1.0.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO GitLab API rate limit reached. Will retry in 30 seconds.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23256 .
[main] INFO A review is required for npm/npmjs/@smithy/service-error-classification/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23257 .
[main] INFO A review is required for npm/npmjs/@smithy/querystring-parser/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23258 .
[main] INFO A review is required for npm/npmjs/@smithy/hash-node/4.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/23259 .

@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review September 5, 2025 12:44
Copy link
Copy Markdown
Member

@ReneSchroederLJ ReneSchroederLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick iteration. Works like a charm with the local bruno version.

Copy link
Copy Markdown
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The dependency checks are okay now. The >1000 LOC are mostly related to the nearly 10k package-lock.json file. It it sill okay since the PR owner is a Committer (see TRG 7.00).

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit d378e8f into eclipse-tractusx:main Sep 8, 2025
14 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/960-dont-duplicate-dtr-contracts branch September 8, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Story] PURIS FOSS skips DTR asset and contract creation based on parameter

3 participants