Skip to content

Correct handling of contract duration #2259

@lgblaumeiser

Description

@lgblaumeiser

Describe the bug

The policy constraint inForceDate has been replaced by Catena-X specific constraints providing the possibility to express permission to use data and obligations to provide data. There are several issues with that:

  1. We make use of inForceDate heavily in end2end tests. Interestingly, these tests did not break in the past but this is only happening since a more or less unrelated change. The constraint "inForceDate" is not allowed anymore.
  2. inForceDate is working with time stamps, whereas the new constraints act in days as granularity. The e2e tests in place make use of the timestamp by creating contracts in the area of 10 seconds, this approach cannot be adopted for the new constraints.
  3. It is not clear, whether the new constraints have been added in a way, that allows the connector to stop creating transfer processes when the contract has expired. As 2 implies, this can also not easily tested due to the granularity.

To Reproduce

Run the disabled tests

Expected behavior

We have reanabled the failing tests and there are tests proving the inability to create transfer processes for expired contracts.

Possible Implementation

You already know the root cause of the erroneous state and how to fix it? Feel free to share your thoughts.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingdecision recordlaterImportant issue, but not urgent

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions