Skip to content

feat(Gateway): forward EDR + refactor#597

Merged
wolf4ood merged 2 commits intoeclipse-tractusx:mainfrom
wolf4ood:feat/451_forward_edr
Jul 11, 2023
Merged

feat(Gateway): forward EDR + refactor#597
wolf4ood merged 2 commits intoeclipse-tractusx:mainfrom
wolf4ood:feat/451_forward_edr

Conversation

@wolf4ood
Copy link
Copy Markdown
Contributor

@wolf4ood wolf4ood commented Jul 10, 2023

WHAT

This PR refactor a bit the provider gateway controller.

  • Removes manual JWT checking
  • Validate the JWT with token validation endpoint
  • Check baseUrl of the HttpData with proxied path configuration
  • Foward the EDR + custom headers.

Also some some docs were added

Closes #451

@wolf4ood wolf4ood force-pushed the feat/451_forward_edr branch 9 times, most recently from 032f7a5 to d3ce164 Compare July 10, 2023 14:19
@wolf4ood wolf4ood force-pushed the feat/451_forward_edr branch from d3ce164 to e1f9b47 Compare July 10, 2023 14:40
@wolf4ood wolf4ood marked this pull request as ready for review July 10, 2023 14:49
@wolf4ood
Copy link
Copy Markdown
Contributor Author

/cc @jimmarino

Comment thread edc-extensions/control-plane-adapter-api/README.md Outdated
Comment thread edc-extensions/control-plane-adapter-api/README.md Outdated
Comment thread edc-extensions/control-plane-adapter-api/README.md Outdated
@wolf4ood wolf4ood force-pushed the feat/451_forward_edr branch from a6d66c1 to 1005463 Compare July 10, 2023 15:20
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@paullatzelsperger paullatzelsperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolf4ood wolf4ood merged commit 10f1117 into eclipse-tractusx:main Jul 11, 2023
@wolf4ood wolf4ood deleted the feat/451_forward_edr branch July 11, 2023 06:37
RoseMgbii-b pushed a commit to RoseMgbii-b/tractusx-edc that referenced this pull request Mar 5, 2026
* feat(Gateway): replaced manual JWT checking with toke validation endpoint call

* fix after reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

DataPlane Gateway forward EDR

3 participants