Skip to content

feat: simplify data encryptor#678

Merged
paullatzelsperger merged 7 commits intoeclipse-tractusx:mainfrom
paullatzelsperger:feat/672_simplify_data_encryptor
Jul 29, 2023
Merged

feat: simplify data encryptor#678
paullatzelsperger merged 7 commits intoeclipse-tractusx:mainfrom
paullatzelsperger:feat/672_simplify_data_encryptor

Conversation

@paullatzelsperger
Copy link
Copy Markdown
Contributor

@paullatzelsperger paullatzelsperger commented Jul 28, 2023 •
edited
Loading

WHAT

Replaces the old, quite convoluted AES data encryptor extension with a sleeker one.
In addition, the bouncy castle provider was replaced with a plain JCE implementation.

WHY

Simplification of code. We don't need layers on layers of factories and providers. KISS.

FURTHER NOTES

  • Currently only AES/GCM with a 128 bit IV is supported. A NoopEncryptor is instantiated as fallback.
  • Postgres test setup was improved slightly

Closes #672

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Jul 28, 2023
@paullatzelsperger paullatzelsperger self-assigned this Jul 28, 2023
@paullatzelsperger paullatzelsperger changed the title Feat/672 simplify data encryptor feat: simplify data encryptor Jul 28, 2023
jimmarino
jimmarino approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓

ndr-brt
ndr-brt approved these changes Jul 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 🪓 🪓

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paullatzelsperger paullatzelsperger merged commit 4c3c559 into eclipse-tractusx:main Jul 29, 2023
RoseMgbii-b pushed a commit to RoseMgbii-b/tractusx-edc that referenced this pull request Mar 5, 2026
@paullatzelsperger
feat: simplify data encryptor (eclipse-tractusx#678)
d16e132 
* feat: replace old data encryptor with simpler implementation

* removed old module

* fix tests attempt 1

* add verbosity flag

* remove schema creation

* sourcedoc

* deactivated Postgres tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

@wolf4ood wolf4ood Awaiting requested review from wolf4ood

+1 more reviewer

@jimmarino jimmarino jimmarino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paullatzelsperger paullatzelsperger

Labels

enhancement New feature or request

Projects

EDC PR Board
Status: Merged

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify the DataEncrypter

3 participants

@paullatzelsperger @jimmarino @ndr-brt
⚡