Skip to content

feat: add API for the BPN validation extension#688

Merged
paullatzelsperger merged 8 commits intoeclipse-tractusx:mainfrom
paullatzelsperger:feat/add_bpn_group_api
Aug 4, 2023
Merged

feat: add API for the BPN validation extension#688
paullatzelsperger merged 8 commits intoeclipse-tractusx:mainfrom
paullatzelsperger:feat/add_bpn_group_api

Conversation

@paullatzelsperger
Copy link
Copy Markdown
Contributor

@paullatzelsperger paullatzelsperger commented Aug 3, 2023

WHAT

Adds a (JSON-LD) REST API for the BusinessPartnerNumber extension that was implemented in #673

  • the module edc-extensions/bpn-validation was restructured:
    • bpn-validation-spi: contains interfaces
    • bpn-validation-core: contains implementations and core clases
    • bpn-validation-api: contains API + controller
    • business-partner-store-sql: contains PostgreSQL implementation for the store.

Using the policy in e2e tests, docker images etc. will come in another PR.

WHY

Clients need to be able to manipulate/seed their BPN groups

FURTHER NOTES

  • API uses JSON-LD to provide consistency
  • integrating these modules in deliverables and more e2e tests will come in a subsequent PR

Closes #673

@paullatzelsperger paullatzelsperger added the enhancement New feature or request label Aug 3, 2023
@paullatzelsperger paullatzelsperger marked this pull request as ready for review August 3, 2023 12:46
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Copy Markdown
Contributor

@wolf4ood wolf4ood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paullatzelsperger paullatzelsperger merged commit 8670f2c into eclipse-tractusx:main Aug 4, 2023
RoseMgbii-b pushed a commit to RoseMgbii-b/tractusx-edc that referenced this pull request Mar 5, 2026
* feat: add BPN group API

* renamed store

* javadoc

* cleanup

* add api and controller

* update license headers

* add test tag

* DEPENDENCIES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Improve the business-partner-validation extensions

2 participants