feat: download opentelemetry jar outside of Dockerfile#697
Merged
paullatzelsperger merged 3 commits intoeclipse-tractusx:mainfrom Aug 9, 2023
paullatzelsperger:feat/686_download_opentelemetry_jar_only_once
Merged
feat: download opentelemetry jar outside of Dockerfile#697paullatzelsperger merged 3 commits intoeclipse-tractusx:mainfrom paullatzelsperger:feat/686_download_opentelemetry_jar_only_once
paullatzelsperger merged 3 commits intoeclipse-tractusx:mainfrom
paullatzelsperger:feat/686_download_opentelemetry_jar_only_once
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
jimmarino
approved these changes
Aug 8, 2023
wolf4ood
approved these changes
Aug 8, 2023
RoseMgbii-b
pushed a commit
to RoseMgbii-b/tractusx-edc
that referenced
this pull request
Mar 5, 2026
…usx#697) * feat: download opentelemetry agent only once * update docker files * update GH action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Downloads the OpenTelemetry Agent jar "outside" of the Dockerfile. This is actually done in two locations:
build.gradle.ktsfile: a Gradle task is added for thispublish-docker-imageaction: a GH Actions step is added, because when publishing we don't use the Gradle Docker taskWHY
Downloading the OTEL Agent inside Docker required adding
curlfirst, and due to security restrictions that required a fixed version. APK, Alpine Linux's package manager, seems to not keep older versions around, which caused the build to break whenever a new version ofcurlwas released.FURTHER NOTES
opentelemetry-javaagent.jaronce per project, directly to each project'sbuild/folder.Closes #686