added support for RetroUSB Genesis RetroPort#484
Open
Patchy68k wants to merge 1 commit intoekeeke:masterfrom
Open
added support for RetroUSB Genesis RetroPort#484Patchy68k wants to merge 1 commit intoekeeke:masterfrom
Patchy68k wants to merge 1 commit intoekeeke:masterfrom
Conversation
Owner
|
Thanks for this pull request, it will indeed be useful to add support for more USB adapters later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first ever real code pull request. It's based on Snes9x GX's code for the Mayflash 2-port SNES adapter. I hope that more adapters will be supported in the future.
After looking at my code again, I've noticed these oversights:
That being said, these issues aren't really serious, and there aren't going to be any problems for players who aren't using this adapter. It's you guys' decision whether this is good enough to get into the master branch.