Add indexed fields to span.context.http.#1438
Merged
simitt merged 3 commits intoelastic:masterfrom Oct 18, 2018
Merged
Conversation
simitt
force-pushed
the
1435-add-span-context-http-fields
branch
from
9cf8e34 to
083a16b
Compare
jalvz
reviewed
Oct 16, 2018
| -- | ||
| type: long | ||
|
|
||
| The status code of the http request. |
Contributor
There was a problem hiding this comment.
nitpick: this is actually the HTTP response.
i am also seeing that we write indifferently HTTP and http, maybe you want to use this opportunity to grep and replace to all caps everywhere in fields ymls / asciidocs
jalvz
approved these changes
Oct 16, 2018
Contributor
Author
|
@elastic/apm-server any concerns about indexing those fields? Otherwise I go forward with it. |
simitt
force-pushed
the
1435-add-span-context-http-fields
branch
from
083a16b to
539999c
Compare
Contributor
Author
|
After another discussion with @eyalkoren I went ahead with only indexing |
simitt
force-pushed
the
1435-add-span-context-http-fields
branch
from
539999c to
1f63501
Compare
Contributor
Author
|
jenkins, retest this please |
Add `status_code` and `method` to `span.context.http` and index them.
simitt
force-pushed
the
1435-add-span-context-http-fields
branch
from
1f63501 to
635072d
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
status_codeandmethodtospan.context.httpand index them. The new fields are added to v1 and v2 as they are an extension of the current schema.There wasn't a big discussion about whether or not to index the fields, but they both seem reasonable to index.
The changes do not automatically show up in the UI, so this would require some work from the @elastic/apm-ui team.
implements #1435