[8.18] (backport #10004) Fix flaky integration tests for the monitoring endpoint#10015
Merged
[8.18] (backport #10004) Fix flaky integration tests for the monitoring endpoint#10015
Conversation
mergify
Bot
requested review from
michel-laterman and
ycombinator
and removed request for
a team
3 tasks
github-actions
Bot
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
swiatekm
approved these changes
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
swiatekm
force-pushed
the
mergify/bp/8.18/pr-10004
branch
from
a394e78 to
b03f466
Compare
swiatekm
approved these changes
Sep 18, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the reliability of the monitoring reload tests and fixes an issue with the fipsonly tests related to testify assertion use. These failures originally surfaced in #9952, and I've also noticed it in #9903, but the fixes are generally applicable, so I'm applying them to all branches.
Why is it important?
Tests should be reliable.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testThis is an automatic backport of pull request #10004 done by [Mergify](https://mergify.com).