Skip to content
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Styling fixes#48

Merged
hazzuk merged 21 commits intomasterfrom
style-fixes
May 7, 2025
Merged

Styling fixes#48
hazzuk merged 21 commits intomasterfrom
style-fixes

Conversation

@hazzuk
Copy link
Copy Markdown
Member

@hazzuk hazzuk commented May 7, 2025

This is a large collection of fixes for numerous issues that were either introduced with elecord 2.2.0's styling changes, or are bugs found in the upstream element-web repository.

Highlights

fix: dm room title ascenders clipping subtitle

e02ce4a, 7c19afb

(old)
room-title-ascenders-old

(new)
room-title-ascenders


fix(user menu): full mxid username cut off

3e9d806

(upstream, element)
remove-mxid-old

(new, elecord)
remove-mxid


fix(notifications): keywords button is full width

7f53869

(upstream, element)
element-notifications-add-button

(new, elecord)
notifications-add-button


chore(settings): disable location sharing feature

c982c16

disable-location-sharing


fix(auth): mas breaks security modal styling

82f42f6, 9079765

(upstream, element)
element-auth-modal

(new, elecord)
new-auth-modal


fix(reply preview): no styling for new msg composer

5388912

msg-composer-reply


fix(spaces): room list joined marker not aligned

92c5078

(upstream, element)
room-list-joined-before

(new, elecord)
room-list-joined-aligned


feat(video rooms): highlight participants icon

28dc149

(new, not joined)
not-joined-new

(new, joined)
joined-new

hazzuk added 20 commits May 4, 2025 03:09
Revert to black on-solid-primary.
Applying !important, forces mx_MessageComposer--compact to use the new styling.
On user rooms with RPC enabled, room titles (the username e.g. 'greg') with ascenders (e.g. 'g') are cut off from the subtitle below.
Previously, a yellow warning emoji was used, but this yellow/gold colour was too similar to the other emojis on the page.
The username displayed in the user menu is a full MXID format. To prevent this issue (in most instances), this removes the matrix.org server name suffix.
The button to add keywords takes up the full width available. Should be much slimmer.
Location sharing is not a feature that makes sense for elecord's use case.
This should be considered a temporary fix. As this issue is also present upstream, and will likely be fixed eventually.
Each modal previously displayed slightly differently.
The move to the Matrix Auth Service means the app no longer uses the light theme after login. Due to this, custom styling has now been set.
At larger sizes, the message composer's border-radius expanded beyond what was originally intended.
Any moving content placed behind text a user needs to read is a bad idea from an accessibility standpoint. This change instead just bakes the gradient into the modal's background.
Most of the default values set in the config never got applied inside the app. So instead, showRedactions (already set) and showTwelveHourTimestamps will be set as part of 'settings.tsx'. The others are no longer required.
When new messages appear, excessive padding is added below the timeline (issue on element as well, though less severe).
The app doesn't support the built-in white theme provided by Element. In future, a custom elecord white theme would need to be developed.
The marker indicating if a user had joined a room was displayed after the room name. This meant markers were never aligned with each another.
Previously, when other users had joined a video room, the difference displayed to the local user was very subtle. Now, the participants icon will always display as a colour, to draw the users attention.
@hazzuk hazzuk added enhancement New feature or request fix Bug fixes labels May 7, 2025
This is a continuation of #e02ce4a. While the room title was no longer being cut off, there was zero space between them with ascending characters (e.g. 'g').
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2025

Cloudflare Pages deployment

Latest commit 7c19afb573d34ebe0e9348b8f254a87d628e47ac
Status ✅ Deployed!
URL https://6805118c.elecord-web.pages.dev

@hazzuk hazzuk merged commit 01f574d into master May 7, 2025
2 checks passed
@hazzuk hazzuk deleted the style-fixes branch May 7, 2025 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request fix Bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant