"Turn on key storage" toast is shown despite it already being turned on

[ccoenen]

Steps to reproduce

1. I opened the element client
2. I was greeted by the toast message that wants me to store keys on the server, giving me two options (dismiss and settings)
3. neither option seems to apply to me, and neither closes the toast message

Also, overall the wording (at least the german translation) is not actionable. I have no clue what my choices are. I'm just being tossed into the settings dialog. When I look for a similar sounding option, it's already checked. If I try to dismiss the message it sounds like I'm doing something wrong.

Outcome

What did you expect?

I expect a message like this to give me a clue what it is about. I expect it to give me options. If it takes me somewhere else (for example the settings) I'd like some hints what I should be looking for in those settings. If the settings are already "correct", the toast should not appear at all.

What happened instead?

Confusion. Enough confusion for me to actually record this whole thing.

Matrix-Fail-nr10000.mp4

Operating system

Linux

Browser information

Within Ferdium, so webkit based browser engine.

URL for webapp

https://app.element.io/

Application version

1.11.105

Homeserver

https://matrix-client.matrix.org

Will you send logs?

Yes

[richvdh]

Thanks very much for reporting this. I've looked at the logs and... I'm mystified. It appears to be some sort of race between the logic that checks the server-side key storage state, and the logic that decides whether to show the toast. But, I've spent a while staring at the code, and can't figure out any way that can possibly happen.

So the best I can do for now is to add more logging, to help us figure out what is going wrong here; I have opened #30291.

[richvdh]

I'm going to close this for now. If you see it again, now that we have landed the improved logging, let us know and we can take another look.

[ccoenen]

The repetition of the message is only part of why I opened it. The whole paragraph below the numbered list still stands. To this day I don't know if I have now completed this correctly or not. My data may be in peril. Or Not. I don't know.

You don't need enhanced logging for unclear wording, instructions, documentation.

[richvdh]

The point is that you shouldn't have seen that toast in the first place. Of course it made no sense to you.