New room list: rename RoomListView as RoomListPanel#29361
Merged
florianduros merged 1 commit intodevelopfrom Feb 26, 2025
Merged
New room list: rename RoomListView as RoomListPanel#29361florianduros merged 1 commit intodevelopfrom
RoomListView as RoomListPanel#29361florianduros merged 1 commit intodevelopfrom
Conversation
florianduros
force-pushed
the
florianduros/new-room-list/rename-roomlistpanel
branch
2 times, most recently
from
1ce055d to
277b066
Compare
florianduros
force-pushed
the
florianduros/new-room-list/rename-roomlistpanel
branch
from
277b066 to
7aebc59
Compare
florianduros
force-pushed
the
florianduros/new-room-list/rename-roomlistpanel
branch
from
7aebc59 to
eb7df98
Compare
dbkr
approved these changes
Feb 26, 2025
florianduros
deleted the
florianduros/new-room-list/rename-roomlistpanel
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
RoomListViewis not a view of the room list. It makes more sense to name itRoomListPanel.Where
RoomListPanelwill includeRoomListSearch,RoomListHeaderand the futurRoomListView(filters + rooms and will useRoomListViewModel)The new room list is still in active development, it's good opportunity to make it right.
The parent folder is renamed as
RoomListPanel.