Skip to content

Remove redundant UserIdentityWarning test#29403

Merged
richvdh merged 2 commits intodevelopfrom
rav/kill_dead_identity_warning_test
Mar 3, 2025
Merged

Remove redundant UserIdentityWarning test#29403
richvdh merged 2 commits intodevelopfrom
rav/kill_dead_identity_warning_test

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented Mar 3, 2025

Since the refactoring in #29067, this test is redundant.

It is also flaky and hard to understand. Time for it to die.

Fixes #29266

Since the refactoring in #29067,
this test is redundant.

It is also flaky and hard to understand. Time for it to die.
Copy link
Copy Markdown
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@richvdh richvdh enabled auto-merge March 3, 2025 15:18
@richvdh richvdh added this pull request to the merge queue Mar 3, 2025
Merged via the queue into develop with commit 4b02520 Mar 3, 2025
@richvdh richvdh deleted the rav/kill_dead_identity_warning_test branch March 3, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

2 participants