Widget: Don't allow un-encrypted to-device traffic if the room is encrypted (parity with rust widget driver)#30241
Closed
BillCarsonFr wants to merge 4 commits intodevelopfrom
Closed
Conversation
BillCarsonFr
changed the title
BillCarsonFr
requested review from
MidhunSureshR and
dbkr
and removed request for
a team
dbkr
approved these changes
Jul 4, 2025
Base automatically changed from
valere/widget/use_new_received_to_device_event
to
develop
July 10, 2025 08:21
toger5
changed the title
Member
|
Sounds like we're not ready to merge this yet due to constraints from existing users of the application. Marking as draft. |
|
This PR has been automatically closed because it has been stale for 180 days. If you wish to continue working on this PR, please ping a maintainer to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #30239
Parity with rust-sdk widget driver.
If the widget is an encrypted room we should only accept encrypted to-device traffic.
Default to encrypted in non-room widgets.
Checklist
public/exportedsymbols have accurate TSDoc documentation.