Merged
Conversation
florianduros
changed the base branch from
dbkr/textualevent_sharedcomponent
to
develop
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
861cc17 to
8e418a4
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
8e418a4 to
bcbe539
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
bcbe539 to
a9cff10
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
5539f4a to
7316292
Compare
florianduros
changed the base branch from
develop
to
dbkr/textualevent_sharedcomponent
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
2 times, most recently
from
2ded009 to
9067864
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
9067864 to
4c19a5c
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
41ae75f to
e7cd854
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
8ef3da9 to
d86d72d
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
2 times, most recently
from
09a9ef3 to
b5d0ab3
Compare
florianduros
force-pushed
the
florianduros/storybook-i18n
branch
from
b5d0ab3 to
3bda3c8
Compare
t3chguy
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the i18n support to storybook to be able to:
_t(),_td()... functionswebapp/i18n/languages.jsonand list them in the storybook headerThe goal is to be able to translate the shared components in storybook without importing all the dependencies of the
languageHandler(akamatrix-js-sdkand half of EW). The needed functions are moved intoshared-components/i18n.tsxand re-exported tolanguageHandler.tsxto avoid breaking change.Screen.Recording.2025-07-16.at.17.18.50.mov