Update for compatibility with v12 rooms by dbkr · Pull Request #30452 · element-hq/element-web

dbkr · 2025-07-31T17:28:26Z

Stop using powerLevelNorm and reading PL events manually.

To support matrix-org/matrix-js-sdk#4937 (but can be merged before).

Checklist

Tests written for new code (and old code if feasible).
New or updated public/exported symbols have accurate TSDoc documentation.
Linter and other CI checks pass.
I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937

t3chguy · 2025-08-04T14:08:42Z

+export function isOnlyAdmin(room: Room, client: MatrixClient): boolean {
+    const currentUserLevel = room.getMember(client.getUserId()!)?.powerLevel;


why not use room.client instead of requiring an extra param

why not use getSafeUserId to avoid !

For 1, only because the docs said it was for lazy loading members so I thought perhaps better to not use it generally, but happy to do so.

t3chguy · 2025-08-04T14:09:00Z

+export function isOnlyAdmin(room: Room, client: MatrixClient): boolean {
+    const currentUserLevel = room.getMember(client.getUserId()!)?.powerLevel;
+
+    const userLevelValues = room.getMembers().map((m) => m.powerLevel);


this assumes all members have already been loaded, which may not be the case due to lazyloading

Won't this also potentially included invited/left members with high PLs?

The fn you replaced used getJoinedMembers instead

Mmm, it's true that lazy loading could potentially be an issue. Fixing this will involve making a leaveRoom async and loading members for every room in a space when we leave it. I'm not sure this is appropriate to do as part of this PR. I have added it to the doc.

and add doc

t3chguy

Should we maybe add a lint rule or deprecation to powerLevelNorm to avoid using it in new code due to -footguns-

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

dbkr · 2025-08-05T08:59:30Z

Well, I'll be removing it altogether shortly after merging this so that shouldn't be a problem.

@andybalaam

Changes in [1.11.110](https://github.com/element-hq/element-web/releases/tag/v1.11.110) (2025-08-27) ==================================================================================================== * Hide recovery key when re-entering it while creating or changing it ([#30499](element-hq/element-web#30499)). Contributed by @andybalaam. * Add `?no_universal_links=true` to OIDC url so EX doesn't try to handle it ([#29439](element-hq/element-web#29439)). Contributed by @t3chguy. * Show a blue lock for unencrypted rooms and hide the grey shield for encrypted rooms ([#30440](element-hq/element-web#30440)). Contributed by @langleyd. * Add support for Module API 1.4 ([#30185](element-hq/element-web#30185)). Contributed by @t3chguy. * MVVM - Introduce some helpers for snapshot management ([#30398](element-hq/element-web#30398)). Contributed by @MidhunSureshR. * A11y: move focus to right panel when opened ([#30553](element-hq/element-web#30553)). Contributed by @florianduros. * Fix e2e warning icon should be white ([#30539](element-hq/element-web#30539)). Contributed by @florianduros. * Remove NoOneHere disabled reason. ([#30524](element-hq/element-web#30524)). Contributed by @toger5. * Fix downloading files with authenticated media API ([#30520](element-hq/element-web#30520)). Contributed by @t3chguy. * Fix call permissions check confusion around element call ([#30521](element-hq/element-web#30521)). Contributed by @t3chguy. * Fix line wrap around emoji verification ([#30523](element-hq/element-web#30523)). Contributed by @t3chguy. * Don't highlight redacted events ([#30519](element-hq/element-web#30519)). Contributed by @t3chguy. * Fix matrix.to links not being handled in the app ([#30522](element-hq/element-web#30522)). Contributed by @t3chguy. * Fix issue of new room list taking up the full width ([#30459](element-hq/element-web#30459)). Contributed by @langleyd. * Fix widget persistence in React development mode ([#30509](element-hq/element-web#30509)). Contributed by @robintown. * Fix widget initialization in React development mode ([#30463](element-hq/element-web#30463)). Contributed by @robintown. Changes in [1.11.109](https://github.com/element-hq/element-web/releases/tag/v1.11.109) (2025-08-11) ==================================================================================================== This release supports the upcoming v12 ("hydra") Matrix room version and is necessary to view and participate in these rooms. * [Backport staging] Allow /upgraderoom command without developer mode enabled ([#30529](element-hq/element-web#30529)). Contributed by @RiotRobot. * [Backport staging] Support for creator/owner power level ([#30526](element-hq/element-web#30526)). Contributed by @RiotRobot. * New room list: change icon and label of menu item for to start a DM ([#30470](element-hq/element-web#30470)). Contributed by @florianduros. * Implement the member list with virtuoso ([#29869](element-hq/element-web#29869)). Contributed by @langleyd. * Add labs option for history sharing on invite ([#30313](element-hq/element-web#30313)). Contributed by @richvdh. * Bump wysiwyg to 2.39.0 adding support for pasting rich text content in the Rich Text Edtior ([#30421](element-hq/element-web#30421)). Contributed by @langleyd. * Support `EventShieldReason.MISMATCHED_SENDER` ([#30403](element-hq/element-web#30403)). Contributed by @richvdh. * Change unencrypted and public pills to blue ([#30399](element-hq/element-web#30399)). Contributed by @florianduros. * Change color of public room icon ([#30390](element-hq/element-web#30390)). Contributed by @florianduros. * Script for updating storybook screenshots ([#30340](element-hq/element-web#30340)). Contributed by @dbkr. * Add toggle to hide empty state in devtools ([#30352](element-hq/element-web#30352)). Contributed by @toger5. * [Backport staging] Use userId to filter users in non-federated rooms when showing the InviteDialog ([#30537](element-hq/element-web#30537)). Contributed by @RiotRobot. * [Backport staging] Catch error when encountering invalid m.room.pinned\_events event ([#30536](element-hq/element-web#30536)). Contributed by @RiotRobot. * Update for compatibility with v12 rooms ([#30452](element-hq/element-web#30452)). Contributed by @dbkr. * New room list: fix tooltip on presence ([#30474](element-hq/element-web#30474)). Contributed by @florianduros. * New room list: add tooltip for presence and room status ([#30472](element-hq/element-web#30472)). Contributed by @florianduros. * Fix: Clicking on an item in the member list causes it to scroll to the top rather than show the profile view ([#30455](element-hq/element-web#30455)). Contributed by @langleyd. * Put the 'decrypting' tooltip back ([#30446](element-hq/element-web#30446)). Contributed by @dbkr. * Use server name explicitly for via. ([#30362](element-hq/element-web#30362)). Contributed by @Half-Shot. * fix: replace hardcoded string in poll history dialog ([#30402](element-hq/element-web#30402)). Contributed by @florianduros. * fix: replace hardcoded string on qr code back button ([#30401](element-hq/element-web#30401)). Contributed by @florianduros. * Fix color of icon button with outline ([#30361](element-hq/element-web#30361)). Contributed by @florianduros. Changes in [1.11.108](https://github.com/element-hq/element-web/releases/tag/v1.11.108) (2025-07-30) ==================================================================================================== * [Backport staging] Fix downloaded attachments not being decrypted ([#30434](element-hq/element-web#30434)). Contributed by @RiotRobot. Changes in [1.11.107](https://github.com/element-hq/element-web/releases/tag/v1.11.107) (2025-07-29) ==================================================================================================== * Message preview should show tooltip with the full message on hover ([#30265](element-hq/element-web#30265)). Contributed by @MidhunSureshR. * Support rendering notification badges on platforms that do their own icon overlays ([#30315](element-hq/element-web#30315)). Contributed by @Half-Shot. * Add SubscriptionViewModel base class ([#30297](element-hq/element-web#30297)). Contributed by @dbkr. * Enhancement: Save image on CTRL+S ([#30330](element-hq/element-web#30330)). Contributed by @ioalexander. * Add quote functionality to MessageContextMenu (#29893) ([#30323](element-hq/element-web#30323)). Contributed by @AlirezaMrtz. * Initial structure for shared component views ([#30216](element-hq/element-web#30216)). Contributed by @dbkr. * [Backport staging] Fix e2e shield being invisible in white mode for encrypted room ([#30411](element-hq/element-web#30411)). Contributed by @RiotRobot. * Force ED titlebar color for new room list ([#30332](element-hq/element-web#30332)). Contributed by @florianduros. * Add a background color to left panel for macos titlebar in element desktop ([#30328](element-hq/element-web#30328)). Contributed by @florianduros. * Fix: Prevent page refresh on Enter key in right panel member search ([#30312](element-hq/element-web#30312)). Contributed by @AlirezaMrtz.

* Update for compatibility with v12 rooms Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937 * Add test for leave space dialog * Don't compute stuff if we don't need it * Use room.client * Use getSafeUserId * Remove client arg * Use getJoinedMembers and add doc * Fix tests * Fix more tests * Fix other test * Clarify comment Co-authored-by: Michael Telatynski <7t3chguy@gmail.com> --------- Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

Update for compatibility with v12 rooms

3eca1de

Stop using powerLevelNorm and reading PL events manually. To support matrix-org/matrix-js-sdk#4937

dbkr added the T-Defect label Jul 31, 2025

github-actions Bot deployed to Netlify July 31, 2025 17:31 View deployment

Merge remote-tracking branch 'origin/develop' into dbkr/hydra

ddbf88a

github-actions Bot deployed to Netlify July 31, 2025 17:36 View deployment

github-actions Bot deployed to EndToEndTests July 31, 2025 17:48 View deployment

Merge branch 'develop' into dbkr/hydra

c42ba2a

github-actions Bot deployed to Netlify August 4, 2025 12:40 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 12:50 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 13:00 View deployment

Add test for leave space dialog

dd0b7a9

github-actions Bot deployed to Netlify August 4, 2025 13:35 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 13:46 View deployment

dbkr marked this pull request as ready for review August 4, 2025 13:46

dbkr requested a review from a team as a code owner August 4, 2025 13:46

dbkr requested review from MidhunSureshR and t3chguy August 4, 2025 13:46

t3chguy reviewed Aug 4, 2025

View reviewed changes

Comment thread src/components/structures/MatrixChat.tsx Outdated

dbkr added 5 commits August 4, 2025 16:03

Don't compute stuff if we don't need it

56b34de

Use room.client

c63e619

Use getSafeUserId

f646164

Remove client arg

bc2cb7a

Use getJoinedMembers

76abd06

and add doc

github-actions Bot deployed to Netlify August 4, 2025 15:15 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 15:25 View deployment

Fix tests

6ea1786

github-actions Bot deployed to Netlify August 4, 2025 15:34 View deployment

Fix more tests

823034c

github-actions Bot deployed to Netlify August 4, 2025 15:44 View deployment

Fix other test

853550c

github-actions Bot deployed to Netlify August 4, 2025 15:52 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 16:05 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 16:22 View deployment

github-actions Bot deployed to EndToEndTests August 4, 2025 16:36 View deployment

dbkr requested a review from t3chguy August 4, 2025 16:39

t3chguy reviewed Aug 5, 2025

View reviewed changes

Comment thread src/utils/membership.ts Outdated

t3chguy approved these changes Aug 5, 2025

View reviewed changes

Clarify comment

0ccbac2

Co-authored-by: Michael Telatynski <7t3chguy@gmail.com>

github-actions Bot deployed to Netlify August 5, 2025 09:02 View deployment

github-actions Bot deployed to EndToEndTests August 5, 2025 09:14 View deployment

github-actions Bot deployed to EndToEndTests August 5, 2025 09:54 View deployment

dbkr added this pull request to the merge queue Aug 5, 2025

dbkr removed this pull request from the merge queue due to a manual request Aug 5, 2025

dbkr added this pull request to the merge queue Aug 5, 2025

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 5, 2025

dbkr added this pull request to the merge queue Aug 5, 2025

Merged via the queue into develop with commit 6a8493c Aug 5, 2025
42 of 44 checks passed

dbkr deleted the dbkr/hydra branch August 5, 2025 11:26

This was referenced Oct 6, 2025

New Element Web release v1.12.0 grueneschweiz/element-web-apache#1

Closed

New Element Web release v1.12.0 grueneschweiz/element-web-apache#2

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update for compatibility with v12 rooms#30452

Update for compatibility with v12 rooms#30452
dbkr merged 13 commits intodevelopfrom
dbkr/hydra

dbkr commented Jul 31, 2025 •

edited

Loading

Uh oh!

t3chguy Aug 4, 2025

Uh oh!

dbkr Aug 4, 2025

Uh oh!

t3chguy Aug 4, 2025

Uh oh!

t3chguy Aug 4, 2025

Uh oh!

t3chguy Aug 4, 2025

Uh oh!

dbkr Aug 4, 2025

Uh oh!

Uh oh!

Uh oh!

t3chguy left a comment

Uh oh!

dbkr commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		export function isOnlyAdmin(room: Room, client: MatrixClient): boolean {
		const currentUserLevel = room.getMember(client.getUserId()!)?.powerLevel;

Uh oh!

Conversation

dbkr commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

t3chguy Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

t3chguy Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

dbkr Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

t3chguy left a comment

Choose a reason for hiding this comment

Uh oh!

dbkr commented Aug 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dbkr commented Jul 31, 2025 •

edited

Loading