Conversation
Merged
1 task
MidhunSureshR
approved these changes
Aug 28, 2025
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #30373
particularly the error here.
A change to floating-ui dependency seems to be calling flushSync which triggers a render of the component and doesn't play nice with this mocking specific hooks and not others.
It probably makes more sense to mock the store data so the hooks are consistent.