MatrixChat: only start session load once#30642
Merged
Conversation
When running in development mode, `MatrixChat.componentDidMount` is run twice, meaning it checks the session lock twice. Sometimes, this means it shows the "Element is running in another window" page. The real problem is of course that we're running all this application logic inside the `MatrixChat` component, but as a quick workaround, we can just remember that we've started the session load code, and bail out on the second pass.
t3chguy
requested changes
Aug 28, 2025
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
This being in the c'tor is a bit of a foot-gun, one wouldn't expect a c'tor to bail early and they may add code at the end, such as the resize listener was and end up suffering
Can you break it out into a private method at least
t3chguy
requested changes
Aug 28, 2025
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
This being in the c'tor is a bit of a foot-gun, one wouldn't expect a c'tor to bail early and they may add code at the end, such as the resize listener was and end up suffering
Can you break it out into a private method at least
Member
|
or invert the condition and move the relevant code into the if edit: the diff was confusing, not the c'tor, |
Member
Author
done |
t3chguy
approved these changes
Aug 28, 2025
This was referenced Sep 3, 2025
Dileep9999
pushed a commit
to hemanth-nag/element-web
that referenced
this pull request
Oct 8, 2025
* MatrixChat: only start session load once When running in development mode, `MatrixChat.componentDidMount` is run twice, meaning it checks the session lock twice. Sometimes, this means it shows the "Element is running in another window" page. The real problem is of course that we're running all this application logic inside the `MatrixChat` component, but as a quick workaround, we can just remember that we've started the session load code, and bail out on the second pass. * Address review comments
snowping
pushed a commit
to Novaloop-AG/element-web
that referenced
this pull request
Dec 30, 2025
* MatrixChat: only start session load once When running in development mode, `MatrixChat.componentDidMount` is run twice, meaning it checks the session lock twice. Sometimes, this means it shows the "Element is running in another window" page. The real problem is of course that we're running all this application logic inside the `MatrixChat` component, but as a quick workaround, we can just remember that we've started the session load code, and bail out on the second pass. * Address review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in development mode,
MatrixChat.componentDidMountis run twice,meaning it checks the session lock twice. Sometimes, this means it shows the
"Element is running in another window" page.
The real problem is of course that we're running all this application logic
inside the
MatrixChatcomponent, but as a quick workaround, we can justremember that we've started the session load code, and bail out on the second pass.