Allow local log downloads when a rageshake URL is not configured.#31716
Allow local log downloads when a rageshake URL is not configured.#31716
Conversation
Half-Shot
changed the title
Half-Shot
added
the
T-Feature
Half-Shot
added
T-Enhancement
and removed
T-Feature
pmaier1
left a comment
pmaier1
left a comment
There was a problem hiding this comment.
Yup, thanks 👍 This change is important for use cases where the service provider does not want to expose debug log information to us but still give users the ability to obtain the information and to forward it elsewhere.
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
This feels really broken, both fields & both buttons are disabled, it is super unclear why the only thing that works is the Download logs button
That's the old UX which I just updated. |
@pmaier1 why wouldn't the service provider not run their own https://github.com/matrix-org/rageshake to have the logs be sent to themselves rather than us? |
|
I think |
That's another possibility, yes. But we do not ship the rageshake server in our distributions today. Taking that into account, we should provide the ability to obtain the data without sending it to us. |
This was always possible by just specifying a dummy value in this field, the |
|
|
||
| const rageshakeSubmitUrl = SdkConfig.get("bug_report_endpoint_url"); | ||
| if (rageshakeSubmitUrl) { | ||
| if (rageshakeSubmitUrl && rageshakeSubmitUrl !== "local") { |
There was a problem hiding this comment.
Can this get a comment explaining the actual behaviour:
- if a local rageshake log is used, the internal EC rageshake flow will not be able to submit logs
- if a remote rageshake url is set, EC will use the same as configured in EW
If that is even correct ^ (if not its even more important to add a comment)
I will give the PR a check from the call side. I would like to see it but its not blocking.
There was a problem hiding this comment.
That is correct. I will add a const so it's clear what "local" does.
There was a problem hiding this comment.
I think it's fine enough to click through to the const if you want to understand what this code does.
…ement-hq#31716) * Add support for storing debug logs locally and allowing local downloads. * static * Comprehensive testing for bug report flow. * Driveby cleanup of typography * fix i18n * Improvements to UX * More testing * update snaps * linting * lint * Fix feedback * Fix boldnewss * fix bold * fix heading * Increase test coverage * remove focus * Don't show the FAQ depending on whether you can submit feedback. * move reset * fix err * Remove unused * update snap * Remove text * Bumping up that coverage * tidy * lint * update snap * Use a const * fix imports * Remove import in e2e test * whoops
5 participants
This is intended to handle the usecase where users do not wish to configure a rageshake server but still be able to send bug reports to us.
Unfortunately we use thebug_report_endpoint_urlto also trigger what feedback forms we show so this will need some tweaking and improving, and a number of playwright tests to ensure our various feedback options still work.Comprehensive playwright tests are now available.
Checklist
public/exportedsymbols have accurate TSDoc documentation.