Custom themes now import highlights in css#31758
Merged
t3chguy merged 1 commit intoelement-hq:developfrom Jan 16, 2026
Merged
Conversation
Added import for codeblock highlights in css for custom themes Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
github-actions
Bot
added
the
Z-Community-PR
t3chguy
reviewed
Jan 16, 2026
| @import "../../../../res/css/_font-sizes.pcss"; | ||
| @import "../../legacy-light/css/_paths.pcss"; | ||
| @import "../../legacy-light/css/_fonts.pcss"; | ||
| @import "../../legacy-light/css/_legacy-light.pcss"; |
Member
There was a problem hiding this comment.
Isn't atom-one-light.min.css already imported by _legacy-light which is imported here
Member
There was a problem hiding this comment.
Ah no it is in legacy-light.pcss (not underscored) instead
Contributor
Author
There was a problem hiding this comment.
Sadly not, it only lists:
/* diff highlight colors */
.hljs-addition {
background: #dfd;
}
.hljs-deletion {
background: #fdd;
}
which are present in built theme-dark-custom.css
but not the rest
It is present in legacy-light.pcss but that is not imported
It could be that it should include legacy-light.pcss instead of url loading the style. But this falls more in line with the rest of the setups in css i think
Merged
via the queue into
element-hq:develop
with commit Jan 16, 2026
e811cf0
51 of 53 checks passed
rbondesson
pushed a commit
to ZacksBot/element-web
that referenced
this pull request
Jan 22, 2026
Added import for codeblock highlights in css for custom themes Signed-off-by: Örnfeldt Philip (66140321) <philip.ornfeldt@forsakringskassan.se>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added import for codeblock highlights in css for custom themes
Checklist
public/exportedsymbols have accurate TSDoc documentation.Fixes #31757
More information about the change is written there.