Refactor Reactions Row Button to shared-components#31993
Merged
ZacksBot merged 101 commits intoelement-hq:developfrom Feb 25, 2026
Merged
Refactor Reactions Row Button to shared-components#31993ZacksBot merged 101 commits intoelement-hq:developfrom
ZacksBot merged 101 commits intoelement-hq:developfrom
Conversation
github-actions
Bot
added
the
Z-Community-PR
23 tasks
ZacksBot
changed the title
florianduros
requested changes
Feb 23, 2026
Comment on lines
+27
to
+31
| className?: string; | ||
| /** | ||
| * The aria-label for the button. | ||
| */ | ||
| ariaLabel?: string; |
Member
There was a problem hiding this comment.
imo it's more legit to pick up these values from HTMLButtonElement
Comment on lines
+10
to
+12
| font: inherit; | ||
| all: unset; | ||
| line-height: var(--cpd-font-size-heading-sm); |
Member
There was a problem hiding this comment.
This is strange to set the line-height and to inherit the font
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
…/ReactionsRowButtonView.tsx Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
florianduros
approved these changes
Feb 24, 2026
…/ReactionsRowButtonView.tsx Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
Co-authored-by: Florian Duros <florian.duros@ormaz.fr>
…RowButton # Conflicts: # apps/web/res/css/views/messages/_ReactionsRowButton.pcss # apps/web/src/components/views/messages/ReactionsRowButton.tsx # apps/web/src/viewmodels/message-body/ReactionsRowButtonViewModel.ts # apps/web/test/unit-tests/components/views/messages/ReactionsRowButton-test.tsx # apps/web/test/unit-tests/components/views/messages/__snapshots__/ReactionsRowButton-test.tsx.snap # apps/web/test/viewmodels/message-body/ReactionsRowButtonViewModel-test.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Refactor ReactionsRowButton to shared-components
Summary
ReactionsRowButtoncomponent to@element-hq/web-shared-componentspackage asReactionsRowButtonViewReactionsRowButtonSnapshotinterfaceChanges
New shared component
Added
ReactionsRowButtonViewunderpackages/shared-components/src/message-body/ReactionsRowButton/with:useViewModelhookAdded ReactionsRowButtonViewModel-test.tsx under
element-web/test/viewmodels/message-bodyCodebase migration
ReactionRow.tsx: Now rendersReactionsRowButtonViewModelinstead of the old componentTest plan
Before & After Refactoring
Closes element-hq/wat-internal#408