Skip to content

Change div to button#32580

Closed
ZacksBot wants to merge 36 commits intoelement-hq:developfrom
ZacksBot:DisibugatedProfiledivtobutton
Closed

Change div to button#32580
ZacksBot wants to merge 36 commits intoelement-hq:developfrom
ZacksBot:DisibugatedProfiledivtobutton

Conversation

@ZacksBot
Copy link
Copy Markdown
Member

@ZacksBot ZacksBot commented Feb 19, 2026

Checklist

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 19, 2026
Comment on lines +89 to +94
<button
type="button"
className={classNames(className, styles.disambiguatedProfile)}
title={title}
onClick={vm.onClick}
onKeyDown={handleKeyDown}
role={vm.onClick ? "button" : undefined}
tabIndex={vm.onClick ? 0 : undefined}
tabIndex={0}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onClick is still optional, so it should probably be a div when !onClick (and with no tabIndex set)

@ZacksBot ZacksBot self-assigned this Feb 19, 2026
@ZacksBot ZacksBot added the T-Task Tasks for the team like planning label Feb 19, 2026
@ZacksBot ZacksBot force-pushed the DisibugatedProfiledivtobutton branch from 80607c2 to 486608a Compare February 20, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants