Confirm before inviting unknown users to a DM/room#33171
Open
Confirm before inviting unknown users to a DM/room#33171
Conversation
3 tasks
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
93e63e0 to
cfb0195
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
2 times, most recently
from
97128e2 to
ff5f894
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
ff5f894 to
5ebbdaf
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
5ebbdaf to
33b88b7
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Factor out the logic of calling `startDm` or `inviteUsers` to a helper function. We're going to need to call this from a second location soon, so this is useful groundwork.
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
33b88b7 to
c5b202a
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
c5b202a to
1cb200b
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
1cb200b to
fd8b28a
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
fd8b28a to
f2c288a
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
f2c288a to
b6bc15f
Compare
richvdh
force-pushed
the
rav/unknown_identity_users_warning_dialog
branch
from
b6bc15f to
cd13015
Compare
dbkr
reviewed
Apr 22, 2026
andybalaam
approved these changes
Apr 22, 2026
Member
andybalaam
left a comment
andybalaam
left a comment
There was a problem hiding this comment.
I agree with Dave's comments (except not particularly keen on making a new component) but nothing else to add from me. Approving so I'm not blocking the process when Dave's comments are resolved.
dbkr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we invite a user whose cryptographic identity is unknown to us to a DM/room, we want to prompt the user for confirmation.
Fixes: element-hq/element-meta#3163
Screenshots: