Skip to content

Phase 2 Refactor MImageBody to MVVM and remove legacy component #33212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZacksBot wants to merge 12 commits into
base: develop
Choose a base branch
from

Merge branch 'develop' into refactor/MVVMMImageBody

a718cd8
Select commit
Loading
Failed to load commit list.
Open

Phase 2 Refactor MImageBody to MVVM and remove legacy component #33212

Merge branch 'develop' into refactor/MVVMMImageBody
a718cd8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 24, 2026 in 1m 19s

Quality Gate failed

Failed conditions
48.4% Coverage on New Code (required ≥ 80%)
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 154 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'onBlur' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwH&open=AZ2vEaoSRumZ-UYKtIwH&pullRequest=33212

Check warning on line 305 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwV&open=AZ2vEaodRumZ-UYKtIwV&pullRequest=33212

Check warning on line 67 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this public static property readonly. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwC&open=AZ2vEaoSRumZ-UYKtIwC&pullRequest=33212

Check failure on line 225 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 30 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwN&open=AZ2vEaoSRumZ-UYKtIwN&pullRequest=33212

Check warning on line 387 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwQ&open=AZ2vEaoSRumZ-UYKtIwQ&pullRequest=33212

Check warning on line 58 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'unknown' overrides all other types in this union type. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwS&open=AZ2vEaodRumZ-UYKtIwS&pullRequest=33212

Check warning on line 181 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwT&open=AZ2vEaodRumZ-UYKtIwT&pullRequest=33212

Check failure on line 218 in packages/shared-components/src/room/timeline/event-tile/body/MImageBodyView/ImageBodyView.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoyRumZ-UYKtIwY&open=AZ2vEaoyRumZ-UYKtIwY&pullRequest=33212

Check warning on line 158 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'reconnectedListener' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwI&open=AZ2vEaoSRumZ-UYKtIwI&pullRequest=33212

Check warning on line 163 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'onImageError' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwJ&open=AZ2vEaoSRumZ-UYKtIwJ&pullRequest=33212

Check failure on line 368 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 29 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwP&open=AZ2vEaoSRumZ-UYKtIwP&pullRequest=33212

Check warning on line 178 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'onImageLoad' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwK&open=AZ2vEaoSRumZ-UYKtIwK&pullRequest=33212

Check warning on line 150 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'onFocus' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwG&open=AZ2vEaoSRumZ-UYKtIwG&pullRequest=33212

Check warning on line 305 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwW&open=AZ2vEaodRumZ-UYKtIwW&pullRequest=33212

Check warning on line 280 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwU&open=AZ2vEaodRumZ-UYKtIwU&pullRequest=33212

Check warning on line 211 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Don't use a zero fraction in the number. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwL&open=AZ2vEaoSRumZ-UYKtIwL&pullRequest=33212

Check failure on line 319 in apps/web/src/viewmodels/message-body/ImageBodyViewModel.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 34 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaodRumZ-UYKtIwX&open=AZ2vEaodRumZ-UYKtIwX&pullRequest=33212

Check warning on line 114 in apps/web/test/viewmodels/message-body/ImageBodyViewModel-test.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEahURumZ-UYKtIwB&open=AZ2vEahURumZ-UYKtIwB&pullRequest=33212

Check failure on line 86 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwF&open=AZ2vEaoSRumZ-UYKtIwF&pullRequest=33212

Check warning on line 498 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`tabIndex` should only be declared on interactive elements. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwR&open=AZ2vEaoSRumZ-UYKtIwR&pullRequest=33212

Check warning on line 324 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `globalThis` over `window`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwO&open=AZ2vEaoSRumZ-UYKtIwO&pullRequest=33212

Check warning on line 211 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer using an optional chain expression instead, as it's more concise and easier to read. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwM&open=AZ2vEaoSRumZ-UYKtIwM&pullRequest=33212

Check warning on line 71 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'image' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwD&open=AZ2vEaoSRumZ-UYKtIwD&pullRequest=33212

Check warning on line 72 in apps/web/src/components/views/messages/MImageReplyBody.tsx

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Member 'placeholder' is never reassigned; mark it as `readonly`. 

See more on https://sonarcloud.io/project/issues?id=element-web&issues=AZ2vEaoSRumZ-UYKtIwE&open=AZ2vEaoSRumZ-UYKtIwE&pullRequest=33212
View more details on SonarQubeCloud
⚡