Move RovingTabIndex to shared component and use it in ActionBarView#33263
Open
rbondesson wants to merge 8 commits intoelement-hq:developfrom
Open
Move RovingTabIndex to shared component and use it in ActionBarView#33263rbondesson wants to merge 8 commits intoelement-hq:developfrom
rbondesson wants to merge 8 commits intoelement-hq:developfrom
Conversation
dbkr
reviewed
Apr 22, 2026
| import { KeyBindingAction } from "./KeyboardShortcuts"; | ||
| import { type FocusHandler } from "./roving/types"; | ||
|
|
||
| export { checkInputableElement, findSiblingElement, RovingStateActionType, RovingTabIndexContext, useRovingTabIndex }; |
Member
There was a problem hiding this comment.
sonar would like your exports done differently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Move RovingTabIndex to shared components
Summary
RovingTabIndexcomponent in shared componentsActionBarViewto use the new component insteadChanges
New component
RovingTabIndexcomponent in shared componentsRovingActionand reversed the dependency for keyboard handlingRovingTabIndexCodebase migration
ActionBarViewto use the new component instead of the current roving implementationTypetoRovingStateActionTypefor readability and adjusted the caller,ForwardDialog,SpotlightDialogandEmojiPickerTest plan
ActionBarViewstorybookcore/roving/...apps/web/...apps/web/...