Room list: edit or remove custom sections by florianduros · Pull Request #33283 · element-hq/element-web

florianduros · 2026-04-23T12:25:32Z

Add actions to be able to edit or remove the custom sections. A new menu is introduced in the section header on each custom sections.

Screen.Recording.2026-04-23.at.16.43.20.mov

Half-Shot · 2026-04-24T08:13:49Z

@@ -14,6 +14,11 @@ import DialogButtons from "../elements/DialogButtons";
 import { _t } from "../../../languageHandler";


(Since you don't have a screenshot, design feedback will end up here 😄 )

https://www.figma.com/design/qurBlLqjf3mRNpyZ1ffamm/ER-213---Sections?node-id=214-25270&t=pLsVx9P23XBqQBY6-4

The padding looks off for the middle text.

Padding around the title is EW default. Compound and EW have different dialog designs and until we decide to update the dialog styles this kind of differences will exist imo

Half-Shot · 2026-04-24T08:15:39Z

+ */
+
+.mx_RemoveSectionDialog {
+    color: var(--cpd-color-text-primary);


You don't have one for CreateSectionDialog. Presumably this is an archaic bug we're fixing, can you leave a comment?

It does https://github.com/element-hq/element-web/blob/develop/apps/web/res/css/views/dialogs/_CreateSectionDialog.pcss#L9

Not an archaic bug, EW dialog uses another color by default

Half-Shot · 2026-04-24T08:19:33Z

+            hasCancel={true}
+        >
+            <Text as="span">{_t("remove_section_dialog|confirmation")}</Text>
+            <Text as="span">{_t("remove_section_dialog|description")}</Text>


ooi, is there a reason for the two spans rather than combining into one?

To have the same formatting than in figma. You prefer to put a <br /> in the translation?

Half-Shot · 2026-04-24T08:23:39Z

                        <Form.Label> {_t("create_section_dialog|label")}</Form.Label>
-                        <Form.TextControl onChange={(evt) => setValue(evt.target.value)} required={true} />
+                        <Form.TextControl
+                            value={value}


fwiw, in my testing I could insert whitetext before or after my section name and it would not be rendered in the list but accepted by this dialog

Half-Shot · 2026-04-24T08:23:54Z

-                        <Form.TextControl onChange={(evt) => setValue(evt.target.value)} required={true} />
+                        <Form.TextControl
+                            value={value}
+                            onChange={(evt) => setValue(evt.target.value)}


Also noting it's possible to have duplicate section names

Yep that is totally possible

Half-Shot · 2026-04-24T08:25:38Z

 }
+
+/**
+ * Edits an existing custom section by showing a dialog to the user to enter the new section name. If the user confirms, it updates the section data in the settings.


Holy line length batman (it would be helpful if this was kept to around 120 chars per line so it was easier to read)

There is no currently formating rules enforcing it

Half-Shot · 2026-04-24T08:26:59Z

+ */
+export async function deleteSection(tag: string): Promise<void> {
+    const sectionData = SettingsStore.getValue("RoomList.CustomSectionData") || {};
+    if (!sectionData[tag]) return;


Should this warn or throw, seems like there is an application bug if we get to this stage?

gaelledel

If a section is empty, we still display "The chats in this section will still be available in your chats list." from the confirmation modal.
See below:

So if the section is empty, could we instead have
Title: Remove section?
Body: Are you sure you want to remove this section?

On contrary if the section contains at least one room, then we can display
Title: Remove section?
Body: Are you sure you want to remove this section? The chats in this section will still be available in your chats list.

florianduros added T-Enhancement T-Feature Request to add a new feature which does not exist right now labels Apr 23, 2026

florianduros mentioned this pull request Apr 23, 2026

Room list: sections - P6 edit or remove sections #32457

Open

github-actions Bot deployed to Netlify April 23, 2026 12:28 View deployment

github-actions Bot deployed to SharedComponentDiffs April 23, 2026 12:28 View deployment

florianduros force-pushed the florianduros/edit-remove-sections branch from 6409b4a to 9842cd6 Compare April 23, 2026 12:36

github-actions Bot deployed to SharedComponentDiffs April 23, 2026 12:39 View deployment

github-actions Bot deployed to Netlify April 23, 2026 12:39 View deployment

github-actions Bot deployed to EndToEndTests April 23, 2026 12:56 View deployment

florianduros added 2 commits April 23, 2026 15:03

feat(sc): add section menu to section header

849e976

feat(rls): add edit and remove sections

3da55bb

florianduros force-pushed the florianduros/edit-remove-sections branch from 9842cd6 to e08f878 Compare April 23, 2026 13:03

github-actions Bot deployed to Netlify April 23, 2026 13:06 View deployment

github-actions Bot deployed to Netlify April 23, 2026 13:09 View deployment

github-actions Bot deployed to EndToEndTests April 23, 2026 13:27 View deployment

florianduros force-pushed the florianduros/edit-remove-sections branch from c98d985 to 9b7b0f0 Compare April 23, 2026 13:31

github-actions Bot deployed to Netlify April 23, 2026 13:34 View deployment

florianduros added 2 commits April 23, 2026 15:36

feat(dialog): add editing mode to CreateSectionDialog

4ccf2b7

feat(dialog): add remove section dialog

a279708

florianduros force-pushed the florianduros/edit-remove-sections branch from 9b7b0f0 to 63a70fb Compare April 23, 2026 13:37

github-actions Bot deployed to Netlify April 23, 2026 13:39 View deployment

github-actions Bot deployed to EndToEndTests April 23, 2026 13:59 View deployment

florianduros force-pushed the florianduros/edit-remove-sections branch from 63a70fb to 77c2191 Compare April 23, 2026 14:36

github-actions Bot deployed to Netlify April 23, 2026 14:47 View deployment

github-actions Bot deployed to EndToEndTests April 23, 2026 15:01 View deployment

florianduros marked this pull request as ready for review April 23, 2026 15:06

florianduros requested a review from a team as a code owner April 23, 2026 15:06

florianduros requested review from Half-Shot and t3chguy April 23, 2026 15:06

Half-Shot requested changes Apr 24, 2026

View reviewed changes

florianduros added 3 commits April 24, 2026 10:30

feat(vm): wire up vm and stores

dee195b

test: update existing snapshots

3eb11d4

test(e2e): add playwright tests to edit and remove a section

fe2d7ae

florianduros force-pushed the florianduros/edit-remove-sections branch from 77c2191 to fe2d7ae Compare April 24, 2026 08:30

github-actions Bot deployed to Netlify April 24, 2026 08:33 View deployment

github-actions Bot deployed to EndToEndTests April 24, 2026 08:51 View deployment

chore: fix remove section i18n key

cb37acb

github-actions Bot deployed to Netlify April 24, 2026 09:13 View deployment

florianduros added 3 commits April 24, 2026 11:27

fix: able to send empty sections

67c6487

chore: update create section editing docs

68878b6

chore: remove useless fallback

0caaac2

github-actions Bot deployed to Netlify April 24, 2026 09:30 View deployment

chore: add logs when section is unknown

3b40921

github-actions Bot deployed to Netlify April 24, 2026 09:34 View deployment

florianduros requested a review from Half-Shot April 24, 2026 09:35

github-actions Bot deployed to EndToEndTests April 24, 2026 09:51 View deployment

florianduros requested a review from gaelledel April 24, 2026 10:40

gaelledel suggested changes Apr 24, 2026

View reviewed changes

		@@ -14,6 +14,11 @@ import DialogButtons from "../elements/DialogButtons";
		import { _t } from "../../../languageHandler";

Uh oh!

Conversation

florianduros commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

florianduros Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gaelledel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

florianduros commented Apr 23, 2026 •

edited

Loading

florianduros Apr 24, 2026 •

edited

Loading